From owner-freebsd-emulation@FreeBSD.ORG  Wed Jan 26 02:13:59 2011
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: freebsd-emulation@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 830C7106566B;
	Wed, 26 Jan 2011 02:13:59 +0000 (UTC)
	(envelope-from julian@freebsd.org)
Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16])
	by mx1.freebsd.org (Postfix) with ESMTP id 550678FC15;
	Wed, 26 Jan 2011 02:13:59 +0000 (UTC)
Received: from julian-mac.elischer.org
	(h-67-100-89-137.snfccasy.static.covad.net [67.100.89.137])
	(authenticated bits=0)
	by vps1.elischer.org (8.14.4/8.14.4) with ESMTP id p0Q24t4M064150
	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
	Wed, 26 Jan 2011 02:05:07 GMT (envelope-from julian@freebsd.org)
Message-ID: <4D3F8357.2070005@freebsd.org>
Date: Tue, 25 Jan 2011 18:13:43 -0800
From: Julian Elischer <julian@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US;
	rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7
MIME-Version: 1.0
To: Mikolaj Golub <to.my.trociny@gmail.com>
References: <86oc77heqk.fsf@kopusha.home.net> <4D3D2DE9.2060004@freebsd.org>
	<86tygwy9p0.fsf@kopusha.home.net>
In-Reply-To: <86tygwy9p0.fsf@kopusha.home.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-emulation@freebsd.org, freebsd-virtualization@freebsd.org
Subject: Re: VirtualBox + VIMAGE
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jan 2011 02:13:59 -0000

On 1/25/11 1:06 PM, Mikolaj Golub wrote:
> On Sun, 23 Jan 2011 23:44:41 -0800 Julian Elischer wrote:
>
>   JE>  On 1/23/11 6:33 AM, Mikolaj Golub wrote:
>
>   >>  As a quick fix I added in VBoxNetFlt-freebsd.c in all "problem" functions
>   >>  CURVNET_SET_QUIET(vnet0) macro, which sets td->td_vnet to default vnet (see the
>   >>  attached patch). This has fixed the issue for me and now I am happily running
>   >>  both VNET jails and VirtualBox machines on my desktop.
>   >>
>   >>  But the way I fixed the issue looks hackish for me. Could someone suggest a
>   >>  better solution?
>   JE>  this is probably at east partially the correct solution.
>   JE>  Usually you should also set the value back to its previous value when
>   JE>  you leave that code as well.
>
> Thank you for the comments. Actually the patch contained CURVNET_RESTORE()
> too. I just did not mentioned it :-). So if it looks like right solution here
> is an "improved" version of the patch: vnet to switch is taken from thread's
> ucred (on interface initialization) or from ifp->if_vnet.

yes I like it.. Now you just need a port person to patch the port :-)

>   >>  In case someone is interested in trying this patch, below are the instructions
>   >>  how to build "VIMAGE safe" vbox driver from ports:
>   >>
>   >>  cd /usr/ports/emulators/virtualbox-ose-kmod
>   >>  make patch
>   >>  cd work
>   >>  patch -p0<   /path/to/VirtualBox-3.2.12.VIMAGE.patch
>   >>  cd ..
>   >>  VIMAGE=1 make
>   >>
>