From owner-dev-commits-src-all@freebsd.org Tue Apr 13 14:46:12 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 026905E2C4D; Tue, 13 Apr 2021 14:46:12 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-to1can01on062c.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe5d::62c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FKT1v5TB0z4mZ2; Tue, 13 Apr 2021 14:46:10 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fcoenJDhBBiBEiue2mfHn40eY6qcR08TVfbX2oc7JwVCiR0gY0Meu7BQkLNTO/HSu6paUEHzVUGv5H870CTCryT3DDNIz3sd0ltUNOevh8IOjSZoPRZBOe8qhauH1ILpCynKgJPRNPXvxRYbNygq4T8YFPKr9qOe7Uzgfr0EKoZLz6J6OTA4TqzyRmSZ2pu7SSzNZTdOoSupWnEncMdorXRH0ONpdNobdcZej1NlDm7jMXc5kFQY0xvX0jR2yShAxqktXwJ3wEkb2oMIUpIJv50MnIymv5qjIfXbT6Pmfdp7w3/m6dqjJIGNlHB4SQGrr2dHRkBNmqJ0fPfXZmj6AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GwawcOVayqK2zePEV+bh1vBrCVBhOZFKE+chcxVAEm0=; b=lXjD4StuVHpmYW7WmoVkip0NV0WF3Q9tHgkWErNswWLWl+2fNgIgzgQ+hOptNsXBBsHwbPeRbrI8OrcIRcnxG85tFPruzksrU8ofmfxonD7gXUc+eMrCbqek/yfjpceBCA+w/aRKadVHgycQfGIXnytPJ6Lgl7W3c7QJSQFrdTeJ391+zPZpBGnHmBISWg1cORWUsRFVwH5Y7XT7yYTedR33HbpNajswwQlXTqpMMY36qb4kU91YWbp7m7dQWnbvwh4h0k3l85BRcv0MCaIdhcXOuJjChlJtOkUn8TlgE28iuHqv1K+6o96mTxBHm/XNN59asLIWgaCVGi6m7wU4fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uoguelph.ca; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GwawcOVayqK2zePEV+bh1vBrCVBhOZFKE+chcxVAEm0=; b=LoeDbpa0oCd1UGOy99rKby5TBnxwflNF07Iqltgggp91IIyONJ2btWf0SHmyJQZL84QHCj50LMU6rpo7Dx1DJCIoCJgTxGlN7w6dZ3fiGsM9/h7I15Hzr0pFT7W4EVTlady3qCxLjTgUk1QOQobeuUTyYx4rUK9EfhsVjgQst3PRQJByDK5TKFP6PlnMFzi6p5y5WJ0ydf0TXAKZm8sHTcJTH46+wEzxZZvjN1Vr2BKy2hiNx8Rx7Nez/bGQheHrhsJdidkFfZkcqQOI1TLPhVfYvw8rjWqU3KC4qbZ8a2hEUrixl3qL/bwh4dalLqepit8gp2fTTBHCRIfIP7FV9g== Received: from YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:19::29) by YQXPR01MB2759.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:48::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.32; Tue, 13 Apr 2021 14:46:09 +0000 Received: from YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM ([fe80::1c05:585a:132a:f08e]) by YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM ([fe80::1c05:585a:132a:f08e%4]) with mapi id 15.20.3999.037; Tue, 13 Apr 2021 14:46:01 +0000 From: Rick Macklem To: Konstantin Belousov , Rick Macklem CC: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: e152bbecb221 - main - param.h: bump __FreeBSD_version for commit 7763814fc9c2 Thread-Topic: git: e152bbecb221 - main - param.h: bump __FreeBSD_version for commit 7763814fc9c2 Thread-Index: AQHXMFycRRmJ6uIj1ECSMLv7lVdZHaqyhfVB Date: Tue, 13 Apr 2021 14:46:01 +0000 Message-ID: References: <202104112153.13BLrZ6B079911@gitrepo.freebsd.org>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 541717f0-531d-4675-9e56-08d8fe8adbbd x-ms-traffictypediagnostic: YQXPR01MB2759: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1417; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BA0NT+DbdqrbOa7nlEWBSsQOl1eYDntS7cKfZpzBUY7fUHswsAQC3tjsaMP+uZyVUyI4KTlT6fPUMSup3HPRLnvo5nziUv8xWnbIxMLP1l7ycIQnesq1/K7TebQufUSc6IK5yJy6sw65tLUriQTi6XXmOfu9l3DgX7Ji26MI1sf6c+Y0M3IflRjKfq4zQcM1w4D/VCffX7dEWEy0amCmHdvzb5gOVIyF33elh0FFGkih3mlwXyEirTCg5LAejWudIn7PoF3fYNFWiVybDc02bMcPQPya/F1an3/cwPJJROG26znd8fnCBLKhRJaOZt2xu3mAgIRw1vQ2TpHemIUsHJuS9xOx7Fbh2SA++BsFQ1vY6A+kP7geIJh1XTMW97xe/KXhJe5HqT02H8KxPKfzvFWOmXJ/Kl/i7HlM3IWqhZJUnDtJ8hhJ8feUpjpvUmC4Q9NNjdJ3/pthEEXX2M6vU/H+cUmHWTp0CYOvOFXha8zL0v0fAGIvB58J8efpN6vGlDZGMhm6Qilk3IMwdTIAjxgMN/+TcHRGSfUzjWZpY2ROwRK00jpvHT8P9gnzV0vcFNeSxvxxo1dfZHdSYy0Cqukcf/m5MZTfKlDmVqON+XAZzniNyH/6LZRv415GIBpY9PAy2CsmpxJsTxwWvkY62HtvX2I6Bx9tlmrskwtl2DREG0FifD9dwbxCLmMlp95+ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(376002)(396003)(346002)(136003)(366004)(39860400002)(83380400001)(54906003)(71200400001)(7696005)(66946007)(66446008)(52536014)(8936002)(110136005)(91956017)(966005)(64756008)(786003)(66476007)(76116006)(5660300002)(66556008)(2906002)(53546011)(6506007)(86362001)(478600001)(8676002)(186003)(316002)(4326008)(33656002)(38100700002)(122000001)(55016002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Hs4b+FU7N0GdiDRXyC4EC6X4iuAGhdilm4OtsLwoSJmoKiadrUKiLpNV6++g?= =?us-ascii?Q?+BxeKYl+5Xcrm2z0NUtyislpcABWf/wfWQYPfc/2RYcifjCrDB3EeqDcbVe/?= =?us-ascii?Q?ZCIOCwTJl3Wr+uVDqdGBhiAlKRelQbK3T5JOLhw5w54ifzrGdmJKMSWPA0Tl?= =?us-ascii?Q?Wtl7Ns6xraOZfOlsjqrelnpwSzJ4DoAJYoVCFsHkqmuzZT7z0s74Hwhvu2pj?= =?us-ascii?Q?DMPTxUJDlFpl2rtZW8prxFrb0SXO99IPKWAJ4BDEOjBot+QxB6alq0n4+4jM?= =?us-ascii?Q?dMIHdG91rrcIHdOJi4J+NqS8zAILCP+6C2XR6ebQLm6zRTBBne/EkIrZCryK?= =?us-ascii?Q?C0cctCPCWfBKC0/eDqhSOVV5tGga0YdKxqd17OTAWUomTbDuMdEHwfJc7jqD?= =?us-ascii?Q?kPPvYvScOQhPZcJB7wyceobkTMIe8fPxDD5RftOlOuAzlcmfdKWMYDSUIpHi?= =?us-ascii?Q?16V5p8952EKiAFCABwfPYNHT7J/FGttWH2R0uCQp8wayGW7kO1XtJjDCpHZd?= =?us-ascii?Q?Ns1V2lPYs7jE4Os7D5AHUnO66pLACGztBXZlSjKavFx4FcRD6kUnVrlt9Fvq?= =?us-ascii?Q?LsLpoTF0YOawzhdZv73k8XhFJXcCq4uScyKYo2lfLGgvxSzmtyqIEeInuJ26?= =?us-ascii?Q?RThVSNsFjz4xT+baFT/5Dm6o7RF07XDUsbHBVI8O1g4CriPsYd8WHOJpKx3F?= =?us-ascii?Q?SeFRRQf598vTmwNIl93Lt1egxdjugOHyWMwU9OmIZuduotw/kAlQT6m8Ut+z?= =?us-ascii?Q?YbjGgHU9M2h3NNDaq1HkxMDLlYp1lzhCnPMhqZ7poqnRf5ZQ/K3iaUngXNEZ?= =?us-ascii?Q?0D73dYpJXzlpeTf4avX6+1r2OFrP7djBHWlHAxtEVNJSSfitVKjCdFegi6TC?= =?us-ascii?Q?YpBGk2Pj1uPZXrN4Ja4NzBd/8TouHNdD2O9qdM7rb2iY8YjT9WAa2u9ab0m1?= =?us-ascii?Q?l+e14VRB9G9T9opgGn6nMEdS19ar5CnLThsyKMp1xxrR97HmER5mHjvtqbr/?= =?us-ascii?Q?X7sGwGEUSYkje9mEVTMqeW46UcXoQr19SE2qfricByMtptPNgOi1Hmt9iXra?= =?us-ascii?Q?MCG9tS5vlv8uNT9Rn8ldunzPSn3XnrSt9rmYOFDaKnU4QqB6QnfTvN5lCFYW?= =?us-ascii?Q?7opIU7uzIv2anRO2NMzmdQ2pPtqZSFKx3LB7YCHhOmMlbzWjE0fjuOWAbIyp?= =?us-ascii?Q?a/0D87dXh1xIx4IpBYYBbnoAwiSlgVEbyni99L2/0MKUij7lgqs8fVyQBPpN?= =?us-ascii?Q?/itaWEIR6Zn+RAjsJzXJUySrROCOx7qE0eEb+YiqBObq9KuMSyG2iVw9mk1I?= =?us-ascii?Q?2RH808+SR5m0WNx7znjKv3e551eOSI55VBbeZnwCRXveYTJ4Am/IUxMEi7G2?= =?us-ascii?Q?tJ8wBfaqXC5R65BWdTie+r5mZjwl?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 541717f0-531d-4675-9e56-08d8fe8adbbd X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2021 14:46:01.7944 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dgvrZVfWNyVlNGTDisVGtqU1nCYaxwemPld+UKiDjnftUNtjl3uBOknL4jX+nfRNsCDlZPkUpBWaa3/OMIKTzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB2759 X-Rspamd-Queue-Id: 4FKT1v5TB0z4mZ2 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 14:46:12 -0000 No problem. The xdr is always needed by the krpc. I tend to forget when the extra dependency is needed, but adding it is certainly harmless. Thanks for doing this, rick ________________________________________ From: Konstantin Belousov Sent: Tuesday, April 13, 2021 8:00 AM To: Rick Macklem Cc: src-committers@freebsd.org; dev-commits-src-all@freebsd.org; dev-commit= s-src-main@freebsd.org Subject: Re: git: e152bbecb221 - main - param.h: bump __FreeBSD_version for= commit 7763814fc9c2 CAUTION: This email originated from outside of the University of Guelph. Do= not click links or open attachments unless you recognize the sender and kn= ow the content is safe. If in doubt, forward suspicious emails to IThelp@uo= guelph.ca On Sun, Apr 11, 2021 at 09:53:35PM +0000, Rick Macklem wrote: > The branch main has been updated by rmacklem: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3De152bbecb221a592e7dbcabe3d= 1170a60f0d0dfe > > commit e152bbecb221a592e7dbcabe3d1170a60f0d0dfe > Author: Rick Macklem > AuthorDate: 2021-04-11 21:47:36 +0000 > Commit: Rick Macklem > CommitDate: 2021-04-11 21:50:56 +0000 > > param.h: bump __FreeBSD_version for commit 7763814fc9c2 > > Commit 7763814fc9c2 changed the internal KAPI between the krpc > and NFS. As such, the krpc, nfscommon and nfscl modules must > all be rebuilt from sources. In fact this commit introduced the dependency between xdr.ko and nfscl.ko. Do you have an objections against the following? commit 717018345b07939cde2db5c6be040cd9de3314cf Author: Konstantin Belousov Date: Tue Apr 13 14:47:20 2021 +0300 nfs client: depend on xdr Since 7763814fc9c27 nfsrpc_setclient() uses mem_alloc() that is macro around malloc(M_RPC). M_RPC is provided by xdr.ko. diff --git a/sys/fs/nfsclient/nfs_clvfsops.c b/sys/fs/nfsclient/nfs_clvfsop= s.c index 365b1c387cc2..08a25c6fe632 100644 --- a/sys/fs/nfsclient/nfs_clvfsops.c +++ b/sys/fs/nfsclient/nfs_clvfsops.c @@ -155,6 +155,7 @@ MODULE_VERSION(nfs, 1); MODULE_DEPEND(nfs, nfscommon, 1, 1, 1); MODULE_DEPEND(nfs, krpc, 1, 1, 1); MODULE_DEPEND(nfs, nfssvc, 1, 1, 1); +MODULE_DEPEND(nfs, xdr, 1, 1, 1); /* * This structure is now defined in sys/nfs/nfs_diskless.c so that it