From owner-svn-src-head@freebsd.org Tue Jul 14 22:18:13 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D1AE635171D; Tue, 14 Jul 2020 22:18:13 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: from mail-yb1-f193.google.com (mail-yb1-f193.google.com [209.85.219.193]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B5vzS3C8Yz4Fgm; Tue, 14 Jul 2020 22:18:12 +0000 (UTC) (envelope-from lwhsu.freebsd@gmail.com) Received: by mail-yb1-f193.google.com with SMTP id 134so174184ybd.6; Tue, 14 Jul 2020 15:18:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KRbgDkkoUR5y0XvW7LmnLi7iIxcHhyR3vwayMEsKlNA=; b=ck50nBlSiqRetSONQKewZonpI3Hk192ueUB2mWOlpqDOFv9arDBwOUvo+OPzuzY6Ez EDhR0hoyLl3LVWz3M6oGjdNxrLQzh6vwtfMQ3HH9k3yrCWUTvBoAwNzDAKqkq0fc6jgh LQv3t2FPqH1+/74GGIYsdKHlInS5fWybUMXtn5Zl39BEP3SZzMNu3S9sULkqwPg4n3eo twAUosqErR2QtlRnGFvPb5xByVR2wYj0AEVyHLRz8x3SgNy2XZNNiR1loDV5kYQ5DaLN HyQ/THzTdYPikoOpe4zAaaqVUc1O0pstw32dyrk/iHg93brNeE1qD2opx5Nn6M9wlljY ltVQ== X-Gm-Message-State: AOAM531/6l27uLKHr+9bzYt8dbRojkzjF8I8fLheamy7QNHweIgIZbB1 eFy9+1GXFTAMJHA3ch7hG2mQMg7wmgEbqE70klCyvdGVZ3U= X-Google-Smtp-Source: ABdhPJz6dBbNdtKBNj8k/uUJWnJPGXCLqoWudFLPf3RBvbbGIAVWoTvc6rz9jeTFPRDOijk7kUkqQMOjF7065TkhEuI= X-Received: by 2002:a25:d104:: with SMTP id i4mr12122384ybg.176.1594765090784; Tue, 14 Jul 2020 15:18:10 -0700 (PDT) MIME-Version: 1.0 References: <202007140154.06E1sOjN003426@repo.freebsd.org> In-Reply-To: From: Li-Wen Hsu Date: Wed, 15 Jul 2020 06:17:59 +0800 Message-ID: Subject: Re: svn commit: r363170 - in head: contrib/byacc contrib/byacc/package contrib/byacc/package/debian contrib/byacc/package/pkgsrc contrib/byacc/test contrib/byacc/test/btyacc contrib/byacc/test/yacc usr... To: Jung-uk Kim Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4B5vzS3C8Yz4Fgm X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of lwhsufreebsd@gmail.com designates 209.85.219.193 as permitted sender) smtp.mailfrom=lwhsufreebsd@gmail.com X-Spamd-Result: default: False [-1.17 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.57)[-0.568]; FROM_NEQ_ENVFROM(0.00)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-0.63)[-0.633]; RCVD_TLS_ALL(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.219.193:from]; NEURAL_SPAM_SHORT(0.03)[0.031]; FORGED_SENDER(0.30)[lwhsu@freebsd.org,lwhsufreebsd@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.219.193:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; MIME_TRACE(0.00)[0:+]; TAGGED_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2020 22:18:14 -0000 On Wed, Jul 15, 2020 at 6:14 AM Li-Wen Hsu wrote: > > On Tue, Jul 14, 2020 at 9:54 AM Jung-uk Kim wrote: > > > > Author: jkim > > Date: Tue Jul 14 01:54:24 2020 > > New Revision: 363170 > > URL: https://svnweb.freebsd.org/changeset/base/363170 > > > > Log: > > MFV: r362513 > > > > Update byacc to 20200330. > > Hello Jung-uk, > > There are some things I haven't figured out, but currently there is > one yacc test case in our CI is failing. > > Please check the output of usr.bin.yacc.yacc_tests.main at > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/15843/testReport/junit/usr.bin.yacc/yacc_tests/main/ > > The yacc processed result of /usr/tests/usr.bin/yacc/calc.y is > different than the reference, > /usr/tests/usr.bin/yacc/yacc/calc.tab.c > > And checking the files under contrib/byacc/ , there are > (1) ./test/calc.tab.c > (2) ./test/btyacc/calc.tab.c > (3) ./test/yacc/calc.tab.c > > (3) is what we want, and that was the source of > /usr/tests/usr.bin/yacc/yacc/calc.tab.c before this import. It was > updated in the new byacc release and matches the behavior of new yacc. > However, currently we install (1) as /usr/tests/usr.bin/yacc/calc.y , Sorry, I mean currently we install (1) as /usr/tests/usr.bin/yacc/yacc/calc.tab.c > the content looks generated by a very old yacc > > The thing I still don't know is why the source of calc.tab.c is > changed as there is no related change in usr.bin/yacc/tests/Makefile . > Surprisingly, removing (1) can restore the old behavior of using (3) > as the source. I haven't checked why that file appears in the upstream > distfile but it did not exist in our old version of byacc, 20170201. > > I'm not sure what's the best way to fix this. The fastest way is just > removing contrib/byacc/test/calc.tab.c , and the following task is > checking with upstream for the intention of adding that file. We may > also want to fix the Makefile or .mk files to make the source of > /usr/tests/usr.bin/yacc/yacc/calc.tab.c not affected by the file with > the same name under different directories. > > BTW, there are some entries need to be added to the ObsoleteFiles.inc, like > /usr/tests/usr.bin/yacc/err_inherit1.y which is > > Please help check this test issue of the new yacc. > > Thanks, > Li-Wen