Date: Wed, 12 Apr 2023 16:43:13 +0200 From: Moin Rahman <bofh@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "<ports-committers@freebsd.org>" <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c89b6f279989 - main - lang/php8[12]: Fix build on aarch64 with ZTS Message-ID: <1FBC4A00-F91C-4A4C-9D3E-A159287BCA43@freebsd.org> In-Reply-To: <ZDa1j/k5bMGxfDH0@FreeBSD.org> References: <202304120539.33C5dOJA014331@gitrepo.freebsd.org> <ZDa1j/k5bMGxfDH0@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_A4F2BC45-E396-4B84-89B2-884351044FD3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Apr 12, 2023, at 3:43 PM, Alexey Dokuchaev <danfe@freebsd.org> = wrote: >=20 > On Wed, Apr 12, 2023 at 05:39:24AM +0000, Muhammad Moinur Rahman = wrote: >> commit c89b6f2799891129e89d1b4fedf8e25865241060 >>=20 >> lang/php8[12]: Fix build on aarch64 with ZTS >>=20 >> - Refresh patches >=20 > What good did it bring other than cloaking the actual fix with tons > of needless, unrelated changes? You've poured a glass of honey into > a bucket of tar. :( >=20 >> PR: 266175 >> Reported by: thresh@nginx.com >=20 > That's pretty scarce description. PR was closed as non-actionable > because you didn't have access to aarch64, until someone(tm) came = along > and pointed out the upstream commit that broke the build. You didn't > describe the problem after that, you ignored most of the comments on > that PR, including the one to reopen it, and of course you failed to > give proper credit in the commit log. >=20 > This is *not* how we do things in FreeBSD. 1. You are not someone who should be saying how we do things in FreeBSD because you yourself do not follow our commit guidelines. 2. The patches were submitted by fluffy@ and the log says that the = author is "Author: Dima Panov <fluffy@FreeBSD.org = <mailto:fluffy@FreeBSD.org>>" so I am not sure how I failed to give proper credit. Undoubtedly you commented on this email without = reading it properly. As I am a very little entity into the project I will give you a life = advice rather than a FreeBSD related one. When you are pointing fingers to = others there are three fingers pointing towards yourself. Kind regards, Moin > ./danfe --Apple-Mail=_A4F2BC45-E396-4B84-89B2-884351044FD3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; = charset=3Dus-ascii"></head><body style=3D"word-wrap: break-word; = -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D""><br = class=3D""><div><br class=3D""><blockquote type=3D"cite" class=3D""><div = class=3D"">On Apr 12, 2023, at 3:43 PM, Alexey Dokuchaev <<a = href=3D"mailto:danfe@freebsd.org" class=3D"">danfe@freebsd.org</a>> = wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div = class=3D"">On Wed, Apr 12, 2023 at 05:39:24AM +0000, Muhammad Moinur = Rahman wrote:<br class=3D""><blockquote type=3D"cite" class=3D"">commit = c89b6f2799891129e89d1b4fedf8e25865241060<br class=3D""><br class=3D""> = lang/php8[12]: Fix build on aarch64 with ZTS<br class=3D""><br = class=3D""> - Refresh patches<br class=3D""></blockquote><br = class=3D"">What good did it bring other than cloaking the actual fix = with tons<br class=3D"">of needless, unrelated changes? You've = poured a glass of honey into<br class=3D"">a bucket of tar. :(<br = class=3D""><br class=3D""><blockquote type=3D"cite" class=3D""> = PR: = 26= 6175<br class=3D""> Reported by: <a = href=3D"mailto:thresh@nginx.com" class=3D"">thresh@nginx.com</a><br = class=3D""></blockquote><br class=3D"">That's pretty scarce description. = PR was closed as non-actionable<br class=3D"">because you didn't = have access to aarch64, until someone(tm) came along<br class=3D"">and = pointed out the upstream commit that broke the build. You = didn't<br class=3D"">describe the problem after that, you ignored most = of the comments on<br class=3D"">that PR, including the one to reopen = it, and of course you failed to<br class=3D"">give proper credit in the = commit log.<br class=3D""><br class=3D"">This is *not* how we do things = in FreeBSD.<br class=3D""></div></div></blockquote>1. You are not = someone who should be saying how we do things in = FreeBSD</div><div>because you yourself do not follow our commit = guidelines.</div><div><br class=3D""></div><div>2. The patches were = submitted by fluffy@ and the log says that the author</div><div>is = "<span style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0); = font-family: FiraCodeNerdFontCompleteM-Regular; font-size: 11px;" = class=3D"">Author: Dima Panov <</span><a = href=3D"mailto:fluffy@FreeBSD.org" style=3D"font-family: = FiraCodeNerdFontCompleteM-Regular; font-size: 11px;" = class=3D"">fluffy@FreeBSD.org</a><span style=3D"caret-color: rgb(0, 0, = 0); color: rgb(0, 0, 0); font-family: FiraCodeNerdFontCompleteM-Regular; = font-size: 11px;" class=3D"">>" so I am not sure how I failed = to</span></div><div>give proper credit. Undoubtedly you commented on = this email without reading</div><div>it properly.</div><div><br = class=3D""></div><div>As I am a very little entity into the project I = will give you a life advice</div><div>rather than a FreeBSD related one. = When you are pointing fingers to others</div><div>there are three = fingers pointing towards yourself.</div><div><br = class=3D""></div><div>Kind regards,</div><div>Moin<br = class=3D""><blockquote type=3D"cite" class=3D""><div class=3D""><div = class=3D"">./danfe<br class=3D""></div></div></blockquote></div><br = class=3D""></body></html>= --Apple-Mail=_A4F2BC45-E396-4B84-89B2-884351044FD3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1FBC4A00-F91C-4A4C-9D3E-A159287BCA43>