From owner-freebsd-ports  Fri Aug 27 15:50:19 1999
Delivered-To: freebsd-ports@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 4B65E1555A
	for <freebsd-ports@FreeBSD.org>; Fri, 27 Aug 1999 15:50:17 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id PAA58809;
	Fri, 27 Aug 1999 15:50:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 926A415544; Fri, 27 Aug 1999 15:47:03 -0700 (PDT)
Message-Id: <19990827224703.926A415544@hub.freebsd.org>
Date: Fri, 27 Aug 1999 15:47:03 -0700 (PDT)
From: sobomax@altavista.net
To: freebsd-gnats-submit@freebsd.org
X-Send-Pr-Version: www-1.0
Subject: ports/13426: [PATCH] Additional functionality and PLIST fixes for wmakerconf port
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         13426
>Category:       ports
>Synopsis:       [PATCH] Additional functionality and PLIST fixes for wmakerconf port
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 27 15:50:01 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator:     Maxim Sobolev
>Release:        4.0-CURRENT
>Organization:
Vega International Capital
>Environment:
>Description:
I'm discovered that wmakerconf port could be improved in following 3 directions:

1. Support for bzip'ed themes (RUN_DEPENDS=bunzip2)
2. Configuration files upgrade via Inet (RUN_DEPENDS=wget,rpm)
3. PLIST should be fixed (see attached patches)

I'm personally thoroughly tested (2) and (3) and it both working flamelessly. As for (1) it should work w/o any doubts.
Please note that BUILD_DEPENDS = wget and bunzip2 is NECESSARY because configure checking for presence of this files and enabling or disabling features according to results.

>How-To-Repeat:
cd /usr/ports/x11-wm/wmakerconf ; make all install
>Fix:
diff -ruN /usr/ports/x11-wm/wmakerconf/Makefile wmakerconf/Makefile
--- /usr/ports/x11-wm/wmakerconf/Makefile	Thu Aug 26 23:44:33 1999
+++ wmakerconf/Makefile	Sat Aug 28 00:56:08 1999
@@ -12,7 +12,11 @@
 
 MAINTAINER=		dr@domix.de
 
-RUN_DEPENDS=	wmaker:${PORTSDIR}/x11-wm/windowmaker
+RUN_DEPENDS=	wmaker:${PORTSDIR}/x11-wm/windowmaker \
+		rpm:${PORTSDIR}/misc/rpm \
+		bunzip2:${PORTSDIR}/archivers/bzip2 \
+		wget:${PORTSDIR}/ftp/wget
+
 LIB_DEPENDS=	gtk12.2:${PORTSDIR}/x11-toolkits/gtk12 \
 		Imlib.4:${PORTSDIR}/graphics/imlib \
 		PropList.1:${PORTSDIR}/devel/libPropList \
@@ -21,6 +25,9 @@
 		tiff.4:${PORTSDIR}/graphics/tiff34 \
 		png.3:${PORTSDIR}/graphics/png \
 		wraster.3:${PORTSDIR}/x11-wm/windowmaker
+
+BUILD_DEPENDS=	bunzip2:${PORTSDIR}/archivers/bzip2 \
+		wget:${PORTSDIR}/ftp/wget
 
 GNU_CONFIGURE=	yes
 USE_GMAKE=		yes
diff -ruN /usr/ports/x11-wm/wmakerconf/pkg/PLIST wmakerconf/pkg/PLIST
--- /usr/ports/x11-wm/wmakerconf/pkg/PLIST	Thu Aug 26 23:44:33 1999
+++ wmakerconf/pkg/PLIST	Sat Aug 28 01:22:27 1999
@@ -29,17 +29,35 @@
 share/wmakerconf/workspace.xpm
 bin/wmakerconf
 bin/mkpreview
+share/locale/ca/LC_MESSAGES/wmakerconf-data.mo
 share/locale/ca/LC_MESSAGES/wmakerconf.mo
+share/locale/cz/LC_MESSAGES/wmakerconf-data.mo
+share/locale/da/LC_MESSAGES/wmakerconf-data.mo
 share/locale/da/LC_MESSAGES/wmakerconf.mo
+share/locale/de/LC_MESSAGES/wmakerconf-data.mo
 share/locale/de/LC_MESSAGES/wmakerconf.mo
+share/locale/el/LC_MESSAGES/wmakerconf-data.mo
+share/locale/es/LC_MESSAGES/wmakerconf-data.mo
+share/locale/fi/LC_MESSAGES/wmakerconf-data.mo
 share/locale/fi/LC_MESSAGES/wmakerconf.mo
+share/locale/fr/LC_MESSAGES/wmakerconf-data.mo
 share/locale/fr/LC_MESSAGES/wmakerconf.mo
+share/locale/hu/LC_MESSAGES/wmakerconf-data.mo
 share/locale/hu/LC_MESSAGES/wmakerconf.mo
+share/locale/it/LC_MESSAGES/wmakerconf-data.mo
 share/locale/it/LC_MESSAGES/wmakerconf.mo
+share/locale/ja/LC_MESSAGES/wmakerconf-data.mo
 share/locale/ja/LC_MESSAGES/wmakerconf.mo
+share/locale/ko/LC_MESSAGES/wmakerconf-data.mo
+share/locale/ko/LC_MESSAGES/wmakerconf.mo
+share/locale/no/LC_MESSAGES/wmakerconf-data.mo
 share/locale/no/LC_MESSAGES/wmakerconf.mo
+share/locale/pt_BR/LC_MESSAGES/wmakerconf-data.mo
 share/locale/pt_BR/LC_MESSAGES/wmakerconf.mo
+share/locale/ro/LC_MESSAGES/wmakerconf-data.mo
+share/locale/ru/LC_MESSAGES/wmakerconf-data.mo
 share/locale/ru/LC_MESSAGES/wmakerconf.mo
+share/locale/sv/LC_MESSAGES/wmakerconf-data.mo
 share/locale/sv/LC_MESSAGES/wmakerconf.mo
-share/locale/ko/LC_MESSAGES/wmakerconf.mo
+share/locale/tr/LC_MESSAGES/wmakerconf-data.mo
 @dirrm share/wmakerconf


>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message