From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Sep 8 22:00:09 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB50A1065683 for ; Mon, 8 Sep 2008 22:00:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A2A488FC1E for ; Mon, 8 Sep 2008 22:00:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m88M09Rd051205 for ; Mon, 8 Sep 2008 22:00:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m88M093j051204; Mon, 8 Sep 2008 22:00:09 GMT (envelope-from gnats) Resent-Date: Mon, 8 Sep 2008 22:00:09 GMT Resent-Message-Id: <200809082200.m88M093j051204@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Andrius Morkūnas" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86F5C106564A for ; Mon, 8 Sep 2008 21:56:58 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 780B08FC13 for ; Mon, 8 Sep 2008 21:56:58 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m88Luwfr031423 for ; Mon, 8 Sep 2008 21:56:58 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m88Luw2d031422; Mon, 8 Sep 2008 21:56:58 GMT (envelope-from nobody) Message-Id: <200809082156.m88Luw2d031422@www.freebsd.org> Date: Mon, 8 Sep 2008 21:56:58 GMT From: "Andrius Morkūnas" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/127223: [patch] audio/last.fm - unbreak build on amd64 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2008 22:00:09 -0000 >Number: 127223 >Category: ports >Synopsis: [patch] audio/last.fm - unbreak build on amd64 >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Sep 08 22:00:09 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Andrius Morkūnas >Release: FreeBSD 7.1-PRERELEASE amd64 >Organization: >Environment: FreeBSD bsd 7.1-PRERELEASE FreeBSD 7.1-PRERELEASE #0: Thu Sep 4 00:42:41 EEST 2008 hinokind@bsd:/usr/obj/usr/src/sys/GENERIC amd64 >Description: Recent audio/last.fm update to version 1.3.2.14 has made the port unbuildable on amd64. build fails while compiling mp3transcode.cpp: mp3transcode.cpp:284: error: no matching function for call to 'qMin(int&, ssize_t)' For some (invalid) reason someone decided to cast int to ssize_t. Because on amd64 (and probably some other platforms) ssize_t is not the same as int, compiler lets you enjoy failed builds. >How-To-Repeat: Try building audio/last.fm on amd64. >Fix: In the same source file function qMin(int, int) is called four times so its safe to assume one more qMin(int, int) instead of qMin(int, ssize_t(int)) wont do anything bad. Other than that I found no problems with the source code. I'm not sure about the USE_GCC=4.2+ in makefile but it was there before, so I put it back. Patch attached with submission follows: diff -ruN last.fm/Makefile last.fm.fixed/Makefile --- last.fm/Makefile 2008-09-07 18:25:11.000000000 +0300 +++ last.fm.fixed/Makefile 2008-09-08 12:51:00.000000000 +0300 @@ -28,7 +28,7 @@ .include .if ${ARCH} == "amd64" -BROKEN= Does not install +USE_GCC=4.2+ .endif post-patch: diff -ruN last.fm/files/patch-src_mp3transcode_mp3transcode.cpp last.fm.fixed/files/patch-src_mp3transcode_mp3transcode.cpp --- last.fm/files/patch-src_mp3transcode_mp3transcode.cpp 1970-01-01 03:00:00.000000000 +0300 +++ last.fm.fixed/files/patch-src_mp3transcode_mp3transcode.cpp 2008-09-08 01:48:48.000000000 +0300 @@ -0,0 +1,11 @@ +--- src/mp3transcode/mp3transcode.cpp.orig 2007-09-27 17:37:07.000000000 +0300 ++++ src/mp3transcode/mp3transcode.cpp 2008-09-08 01:43:36.000000000 +0300 +@@ -281,7 +281,7 @@ + { + int length; + int cnt; +- length = qMin( numBytes, ssize_t( getDecodedBufferFilled() ) ); ++ length = qMin( numBytes, getDecodedBufferFilled() ); + + while (length > 0) + { >Release-Note: >Audit-Trail: >Unformatted: