From owner-freebsd-bugs@FreeBSD.ORG Wed Oct 27 23:20:34 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 66F1516A4D5 for ; Wed, 27 Oct 2004 23:20:34 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56C5443D58 for ; Wed, 27 Oct 2004 23:20:34 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i9RNKYtI031544 for ; Wed, 27 Oct 2004 23:20:34 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i9RNKY0U031543; Wed, 27 Oct 2004 23:20:34 GMT (envelope-from gnats) Date: Wed, 27 Oct 2004 23:20:34 GMT Message-Id: <200410272320.i9RNKY0U031543@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: David Xu Subject: Re: kern/72979: unkillable process(es) stuck in `STOP' state X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: David Xu List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Oct 2004 23:20:34 -0000 The following reply was made to PR kern/72979; it has been noted by GNATS. From: David Xu To: Ken Smith Cc: Mikhail Teterin , Michael Nottebrock , re@freebsd.org, davidxu@t2t2.com, davidxu@viatech.com.cn, freebsd-gnats-submit@freebsd.org Subject: Re: kern/72979: unkillable process(es) stuck in `STOP' state Date: Thu, 28 Oct 2004 07:19:57 +0800 Ken Smith wrote: >On Tue, Oct 26, 2004 at 12:07:47PM -0400, Mikhail Teterin wrote: > > >>=On Tue, Oct 26, 2004 at 07:11:54PM +0800, David Xu wrote: >>=That looks both promising (given symptoms) and low-risk. >>= >>=Mikhail et. al., will you have any problems testing that? >> >>This problem was not easy to reproduce to begin with :-( >> >>I don't even know, how it can be positively claimed gone. Shall we merge >>David's fix into RELENG_5 and hope for the best? >> >> -mi >> >> > >Has anyone had time to test David's patch? If yes have you had >any problems since? > >I should know later today if the other person who had been reporting >problems has had them stop. He reported last night he was still able >to reproduce the problem but he hasn't had any "luck" doing it today. > >David, my only real question I guess is whether perhaps P_STOPPED_SINGLE >should be added to the flags that are being turned off by your patch. >If I'm following the code right what had made P_STOPPED_TRACE special >was it's one of the three signals lumped into P_STOPPED and the code >in do_tdsignal() looks for that, as well as I'm sure the schedulers... > > > P_STOPPED_SINGLE needn't be removed here, in fact, the flag should already be turned off at this point, if the flag is still there, then there must be a bug, thread_single(SINGLE_EXIT) should turn it off if it returns or thread will exit in the function. P_STOPPED_TRACE is cleared by debugger via PT_DETACH in sys_process.c, but if debugger dies without chance to call ptrace(PT_DETACH), then exit1() must clear it. David Xu