From owner-freebsd-current@freebsd.org Mon Jan 11 18:09:00 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6E2944E117E for ; Mon, 11 Jan 2021 18:09:00 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DF1tM1qtWz4cRx for ; Mon, 11 Jan 2021 18:08:58 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [178.17.145.105]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 54694260420; Mon, 11 Jan 2021 19:08:55 +0100 (CET) Subject: Re: Panic after updating To: Jakob Alvermark , FreeBSD Current , Mateusz Guzik References: <87512669-f0b9-eb2f-1103-170a29384ea8@alvermark.net> <34a9dafd-9690-1b33-abf8-017ad31cf2ab@alvermark.net> From: Hans Petter Selasky Message-ID: Date: Mon, 11 Jan 2021 19:08:43 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <34a9dafd-9690-1b33-abf8-017ad31cf2ab@alvermark.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4DF1tM1qtWz4cRx X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.28 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net:c]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; RBL_DBL_DONT_QUERY_IPS(0.00)[2a01:4f8:c17:6c4b::2:from]; NEURAL_SPAM_SHORT(0.02)[0.018]; SPAMHAUS_ZRD(0.00)[2a01:4f8:c17:6c4b::2:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEMAIL_TO(0.00)[alvermark.net,freebsd.org,gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 18:09:00 -0000 On 1/11/21 5:24 PM, Jakob Alvermark wrote: > > On 1/11/21 1:14 PM, Hans Petter Selasky wrote: >> On 1/11/21 11:12 AM, Jakob Alvermark wrote: >>> >>> Updated my Acer laptop from r367734 to main-c255666-g1790f5e654f >>> >>> >>> Rebooting with the newly build kernel i get this panic. >>> >>> >>> Fatal    trap 12: page fault while in kernel mode >>> >>> cpuid    = 1; apic id = 02 >>> fault    virtual address     = 0x1030000 >>> fault    code                = supervisor read data, >>> >>> instruction    pointer       = 0x20:0xffffffff809e5265 >>> stack    pointer             = 0x28:0xffffffff8281db70 >>> frame    pointer             = 0x28:0xffffffff8281db70 >>> code    segment              = base 0x0, limit 0xfffff, type 0x1b >>> =    DPL 0, pres 1, long 1, def32 0, gran 1 >>> processor    eflags  = interrupt enabled, resume, IOPL = 0 >>> current    process           = 12 (irq88: xhci0) >>> trap    number               = 12 >>> panic:    page fault >>> cpuid    = 1 >>> time    = 2 >>> KDB:    stack backtrace: >>> db_trace_self_wrapper()    at db_trace_self_wrapper+0x2b/frame >>> 0xffffffff8281d820 >>> vpanic()    at vpanic+0x181/frame 0xffffffff8281d870 >>> panic()    at panic+0x43/frame 0xffffffff8281d8d0 >>> trap_fatal()    at trap_fatal+0x387/frame 0xffffffff8281d930 >>> trap_pfault()    at trap_pfault+0x4f/frame 0xffffffff8281d990 >>> trap()    at trap+0x280/frame 0xffffffff8281daa0 >>> calltrap()    at calltrap+0x8/frame 0xffffffff8281daa0 >>> ---    trap 0xc, rip = 0xffffffff809e5265, rsp = 0xffffffff8281db70, >>> rbp = 0xffffffff8281db70 --- >>> usbd_get_page()    at usbd_get_page+0x65/frame 0xffffffff8281db70 >>> xhci_interrupt_poll()    at xhci_interrupt_poll+0x29/frame >>> 0xffffffff8281dc20 >>> xhci_interrupt()    at xhci_interrupt+0x11a/frame 0xffffffff8281dc60 >>> ithread_loop()    at ithread_loop+0x24f/frame 0xffffffff8281dcf0 >>> fork_exit()    at fork_exit+0x7e/frame 0xffffffff8281dd30 >>> fork_trampoline()    at fork_trampoline+0xe/frame 0xffffffff8281dd30 >>> ---    trap 0, rip = 0, rsp = 0, rbp = 0 --- >>> KDB:    enter: panic >>> >>> >>> Any help appreciated. >> >> Hi, >> >> If you could bi-sect that panic, would be great. >> >> Else install gdb from ports and run: >> >> kgdb101 >> >> info line *(usbd_get_page+0x65) >> >> > > Having just learned how to bisect (thanks Warner for the mini primer) > this is the result: > > de0b2d4f47bad36025dcf52755ce76cca6e715d9 is the first bad commit > You mean this commit is causing the panic? > git show de0b2d4f47bad36025dcf52755ce76cca6e715d9 > commit de0b2d4f47bad36025dcf52755ce76cca6e715d9 > Author: Mateusz Guzik > Date: Sun Dec 13 21:30:42 2020 +0000 > > Patch annotation in sigdeferstop > > Probability flipped since sigdefer handling was moved away from regular VOP > calls. > > Notes: > svn path=/head/; revision=368616 > > diff --git a/sys/sys/signalvar.h b/sys/sys/signalvar.h > index 93ef15bbbf0..df761a1e1a5 100644 > --- a/sys/sys/signalvar.h > +++ b/sys/sys/signalvar.h > @@ -367,7 +367,7 @@ static inline int > sigdeferstop(int mode) > { > > - if (__predict_true(mode == SIGDEFERSTOP_NOP)) > + if (__predict_false(mode == SIGDEFERSTOP_NOP)) > return (SIGDEFERSTOP_VAL_NCHG); > return (sigdeferstop_impl(mode)); > } And: git show de0b2d4f47bad36025dcf52755ce76cca6e715d9 | patch -p1 -R gets you a working kernel? --HPS