Date: Thu, 14 Sep 2023 22:42:15 +0000 From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: maintainer-feedback requested: [Bug 273806] x11/libXcursor: Avoid duplicated path in XCURSORPATH Message-ID: <bug-273806-7141-bUGffKoKuG@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-273806-7141@https.bugs.freebsd.org/bugzilla/> References: <bug-273806-7141@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Guido Falsi <madpilot@FreeBSD.org> has asked freebsd-x11 (Nobody) <x11@FreeBSD.org> for maintainer-feedback: Bug 273806: x11/libXcursor: Avoid duplicated path in XCURSORPATH https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273806 --- Description --- Created attachment 244858 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D244858&action= =3Dedit patch v1 by default libXcursor is being build passing to it an ICONDIR that causes t= he configure script to define an XCURSORPATH with that value duplicated. This = can be seen in any build log, the cc commands get this argument: -DXCURSORPATH=3D\"~/.local/share/icons:~/.icons:/usr/local/share/icons:/usr= /local /share/pixmaps:/usr/local/share/icons\" This is causing issues with xfce4-mouse-settings from xfce4-settings port, which scans this path for cursor themes. This software performs no checks f= or duplicates, so cursor themes are duplicated in the UI. The details of this are in bug #273744 I have checked the configure script, which has some simple check to try to = avid such duplicates, but actually fails due to variable substitutions being performed in multiple steps and the check for equal variables fails to catch our path. So, to avoid this, I thought we could directly pass the full xcursor search path with the configure --with-cursorpath variable, so we have full control over it. Testing in poudriere shows it does what it is expected, I'm going to run te= st it on my machines as soon the build run ends. Can this be approved? Thanks in advance.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-273806-7141-bUGffKoKuG>