From owner-freebsd-arch@FreeBSD.ORG  Sat Oct 16 18:32:03 2004
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 46AC816A4CE; Sat, 16 Oct 2004 18:32:03 +0000 (GMT)
Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E962C43D54; Sat, 16 Oct 2004 18:32:02 +0000 (GMT)
	(envelope-from das@FreeBSD.ORG)
Received: from VARK.MIT.EDU (localhost [127.0.0.1])
	by VARK.MIT.EDU (8.13.1/8.12.10) with ESMTP id i9GIW2pe077051;
	Sat, 16 Oct 2004 14:32:02 -0400 (EDT)
	(envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by VARK.MIT.EDU (8.13.1/8.12.10/Submit) id i9GIW296077050;
	Sat, 16 Oct 2004 14:32:02 -0400 (EDT)
	(envelope-from das@FreeBSD.ORG)
Date: Sat, 16 Oct 2004 14:32:02 -0400
From: David Schultz <das@FreeBSD.ORG>
To: "David O'Brien" <obrien@FreeBSD.ORG>
Message-ID: <20041016183202.GA76917@VARK.MIT.EDU>
Mail-Followup-To: David O'Brien <obrien@FreeBSD.ORG>,
	freebsd-arch@FreeBSD.ORG
References: <20041016174419.GA96297@dragon.nuxi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041016174419.GA96297@dragon.nuxi.com>
cc: freebsd-arch@FreeBSD.ORG
Subject: Re: Proposal to restore traditional BSD behavior in <strings.h>.
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Oct 2004 18:32:03 -0000

On Sat, Oct 16, 2004, David O'Brien wrote:
> I'd like to restore the traditional BSD behavior that <strings.h>
> includes the content of <string.h> in addition to the BSD bcmp, et. al.
> We changed our <strings.h> between 4.x and 5.x and now that we're at
> 5-STABLE I'm finding software that built fine on 4.x has an issue on 5.x.

It has been this way for 2.5 years, and nobody has complained
until now AFAIK.  Therefore, it seems unlikely that there's enough
affected unportable software out there to justify undoing the
efforts at reducing namespace pollution now.

Moreover, there's a *lot* of pollution in string.h, where as
strings.h has very little.  Polluting strings.h again increases
the chances that portable applications that use strings.h will
break due to naming conflicts.

> Index: strings.h
> ===================================================================
> RCS file: /home/ncvs/src/include/strings.h,v
> retrieving revision 1.6
> diff -u -r1.6 strings.h
> --- strings.h	23 Jul 2004 07:13:35 -0000	1.6
> +++ strings.h	16 Oct 2004 17:09:40 -0000
> @@ -31,6 +31,7 @@
>  
>  #include <sys/cdefs.h>
>  #include <sys/_types.h>
> +#include <string.h>

You'd want to wrap this in #if __BSD_VISIBLE as well...