Date: Tue, 01 Sep 2020 01:39:53 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 249044] net-mgmt/networkmgr: packaging failure if PREFIX != LOCALBASE + invalid action in non-install steps Message-ID: <bug-249044-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D249044 Bug ID: 249044 Summary: net-mgmt/networkmgr: packaging failure if PREFIX !=3D LOCALBASE + invalid action in non-install steps Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: ericbsd@FreeBSD.org Reporter: jcfyecrayz@liamekaens.com Flags: maintainer-feedback?(ericbsd@FreeBSD.org) Assignee: ericbsd@FreeBSD.org Created attachment 217682 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D217682&action= =3Dedit [patch] fix plist for various issues (a) 'check-plist' fails if PREFIX !=3D LOCALBASE [1] (b) setup.py does 'sudo gtk-update-icon-cache' unconditionally. Only 'make install' should touch anything outside WRKDIR (e.g., not 'make configure' or 'make stage', etc.). It's also unnecessary since INSTALLS_ICON handles tha= t in the FreeBSD ports infrastructure. (c) __VERSION__ in setup.py should be 4.1; the wrong version also causes check-plist to fail even after fixing the hard-coded {prefix}/ instances in setup.py (see patch). [1] [1] =3D=3D=3D=3D> Checking for pkg-plist issues (check-plist) =3D=3D=3D> Parsing plist =3D=3D=3D> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: %%PYTHON_SITELIBDIR%%/networkmgr-%%PYTHON_VER%%-py%%PYTHON_VER%%.egg-info/P= KG-INFO Error: Orphaned: %%PYTHON_SITELIBDIR%%/networkmgr-%%PYTHON_VER%%-py%%PYTHON_VER%%.egg-info/S= OURCES.txt Error: Orphaned: %%PYTHON_SITELIBDIR%%/networkmgr-%%PYTHON_VER%%-py%%PYTHON_VER%%.egg-info/d= ependency_links.txt Error: Orphaned: %%PYTHON_SITELIBDIR%%/networkmgr-%%PYTHON_VER%%-py%%PYTHON_VER%%.egg-info/r= equires.txt Error: Orphaned: %%PYTHON_SITELIBDIR%%/networkmgr-%%PYTHON_VER%%-py%%PYTHON_VER%%.egg-info/t= op_level.txt Error: Orphaned: /usr/local/etc/sudoers.d/networkmgr Error: Orphaned: /usr/local/etc/xdg/autostart/networkmgr.desktop Error: Orphaned: /usr/local/share/icons/hicolor/128x128/apps/nm-adhoc.png Error: Orphaned: /usr/local/share/icons/hicolor/128x128/apps/nm-device-wired-secure.png Error: Orphaned: /usr/local/share/icons/hicolor/128x128/apps/nm-no-connection.png Error: Orphaned: /usr/local/share/icons/hicolor/128x128/apps/nm-signal-00-secure.png Error: Orphaned: /usr/local/share/icons/hicolor/128x128/apps/nm-signal-00.p= ng . . . Patch tested okay in poudriere with default PREFIX and PREFIX=3D/opt. The patch does: Don't override --prefix with hard-coded python prefix. Paths are relative to prefix by default anyway. Don't run sudo gtk-update-icon-cache unconditionally any time setup.py is executed (config, build, whatever). The FreeBSD ports infrastructure handl= es this with INSTALLS_ICONS=3Dyes. For standalone installs, I'm not sure how this should be handled with distutils - it probably should be done outside setup.py. For now, just comment that out. Plus this should not be hard-coded to /usr/local/share... Set correct networkmgr pkg version. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-249044-7788>