From owner-svn-src-all@FreeBSD.ORG Mon Mar 30 15:27:20 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5C7BC47C; Mon, 30 Mar 2015 15:27:20 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 531C714F; Mon, 30 Mar 2015 15:27:19 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t2UFR7D3044608 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 30 Mar 2015 18:27:07 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t2UFR7rN044607; Mon, 30 Mar 2015 18:27:07 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 30 Mar 2015 18:27:07 +0300 From: Gleb Smirnoff To: Emeric POUPON Subject: Re: svn commit: r280759 - head/sys/netinet Message-ID: <20150330152707.GP64665@FreeBSD.org> References: <20150329210757.GA64665@FreeBSD.org> <551933AF.4080300@selasky.org> <20150330120700.GH64665@FreeBSD.org> <551943B4.90102@selasky.org> <20150330125115.GI64665@FreeBSD.org> <551948A4.1070408@selasky.org> <5519535C.40608@selasky.org> <20150330141616.GC74532@zxy.spb.ru> <1872802434.26738716.1427729028579.JavaMail.zimbra@stormshield.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1872802434.26738716.1427729028579.JavaMail.zimbra@stormshield.eu> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Hans Petter Selasky , Adrian Chadd , src-committers@freebsd.org, Ian Lepore , svn-src-all@freebsd.org, Slawa Olhovchenkov , svn-src-head@freebsd.org, Fabien Thomas X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2015 15:27:20 -0000 On Mon, Mar 30, 2015 at 05:23:48PM +0200, Emeric POUPON wrote: E> Hello, E> E> Sorry for late response, I didn't notice this issue was discussed here. E> E> In one of our tests, we have several (up to 12) cpu that emit packets with the same src, dst and protocol to a remote host. E> We did this patch since we observed bad packet reassembly on the remote host, due to different fragments emitted with the same ip id. E> It was an IPsec test (emitting ESP packets) but I guess we could easily reproduce this problem using several "ping -i 0 -s BIG_SIZE_HERE DST" commands running in parallel. E> E> Even if we reached something like 1M pps, it is likely that we did not see any performance penalty since the IPsec stack is quite time consuming. E> Now, the question is: is there a real performance issue here or is it likely to be hidden by other problems? E> E> If it is a real problem, maybe an acceptable tradeoff would be to make the counter per CPU and: E> - initialize it with the cpu id, E> - increment it by the number of cpus. E> E> What do you think? I already posted a patch that makes the counter per CPU. Can you please test it? -- Totus tuus, Glebius.