From owner-freebsd-ports@freebsd.org Mon Mar 5 15:25:42 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 75A00F37D48 for ; Mon, 5 Mar 2018 15:25:42 +0000 (UTC) (envelope-from ashfixit@gmail.com) Received: from mail-yw0-x232.google.com (mail-yw0-x232.google.com [IPv6:2607:f8b0:4002:c05::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 05B0A7E991 for ; Mon, 5 Mar 2018 15:25:42 +0000 (UTC) (envelope-from ashfixit@gmail.com) Received: by mail-yw0-x232.google.com with SMTP id x197so5742023ywg.11 for ; Mon, 05 Mar 2018 07:25:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=19EVA2bI/Gqz9MBelfMnTB6MKtwRey6KaBsxiZYdC58=; b=j0QIm11QChcVI2ZVlHEnjZW8G9AX+GY+m3QCf/CBzuN2yvnUWikmP0qUV+7/UiaU2F HfDigR14xLfSoCm3OGdQP/46jvyjUgDiFcFEOrRrrmnw7ylGsLVUCBaDL/QE4wTP2310 XEURxX73WzKEPOQSVweqGE5oj6XVQVFCi+nLNbUnAQVyVYZzs0LQUgqBmCWdHYtgzsBX hPCtfM46vdsXPA4STHB6lgCts7U3AeBE35i4lq1dtpSV0f+RGuGFpi7F1UhuZnL3WBf5 n7B+HuaH00Kad2FUrud/+awNjnB9cvge4jUcJ/IW2bfiMMzRln6nQvLWiKl0dvdPBzcJ GdHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=19EVA2bI/Gqz9MBelfMnTB6MKtwRey6KaBsxiZYdC58=; b=mlSk87mB/oIDJ9yPP9v6RkqFr+d0/FnYVXbPkSuGGVIci9f69GDLxpfJHuhdOcjz46 6iyDTLhQ2puhEKIL8rTdICVnjdYL1hZtH/g+SSP0xcbl+jjPAFTRYDyehNRIbGlXNABL tk8xmoVuF9Hz6HX1WBPmiVQsc4hNuM3hvzXeqoQwNXuruRgDxF/CeT9mFkWNemm0mWp8 jwZJ6MuKGRAVEa/S0SUZrMwFFlb9JmKag2CrYq4anskec8eLMp0m+8eTmf/R5P2DWhck bUIUzf37g80OrAJDLklBHuihJLr8Gu7aJCJGrLW+etbhMULjGoqyrtYQ/PaDD1c/omyD VGAg== X-Gm-Message-State: AElRT7Fh5AQqNtRHMbX+WBPLidWXt0JpWud9EpEFnw0Vcz8AwLV+68iN LJCcPg3YZHPfzGM3WtInz1nLw5m3L9x8H++Ar6Wx3w== X-Google-Smtp-Source: AG47ELtKclOU1qAmtHy6HFvABiwJPA3EwkGxU7J+0WSVX3WXeasTUN4M9NOFoySUVsRuYYJb2A9v8Uqcz3gKTAbCHjE= X-Received: by 10.129.238.6 with SMTP id l6mr9331671ywm.218.1520263541198; Mon, 05 Mar 2018 07:25:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.113.69 with HTTP; Mon, 5 Mar 2018 07:25:40 -0800 (PST) In-Reply-To: <1520182718.1126475.1291006864.4F744B98@webmail.messagingengine.com> References: <20180303044839.GA32429@home.opsec.eu> <5A9A2A97.5090401@grosbein.net> <20180303050654.GB32429@home.opsec.eu> <1520059234.309443.1289947728.44653321@webmail.messagingengine.com> <20180303080634.GC32429@home.opsec.eu> <20180303185149.GD32429@home.opsec.eu> <1520182718.1126475.1291006864.4F744B98@webmail.messagingengine.com> From: Ash Gokhale Date: Mon, 5 Mar 2018 10:25:40 -0500 Message-ID: Subject: Re: net/viamillipede seeks commiter To: Josh Paetzel Cc: Kurt Jaeger , Kurt Jaeger , Diane Bruce , freebsd-ports@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2018 15:25:42 -0000 On Sun, Mar 4, 2018 at 11:58 AM, Josh Paetzel wrote: > > > On Sat, Mar 3, 2018, at 12:51 PM, Kurt Jaeger wrote: > > > -- > > pi@opsec.eu +49 171 3101372 2 years > to go ! > > I get a different failure on 10.4 using poudriere: > > --- rx.o --- > rx.c:182:14: error: expected ')' > (void *(* _Nonnull)(void *))&rxworker, > ^ > rx.c:182:11: note: to match this '(' > (void *(* _Nonnull)(void *))&rxworker, > ^ > 1 error generated. > --- tx.o --- > tx.c:317:14: error: expected ')' > (void *(* _Nonnull)(void *))&txworker_sm, > ^ > tx.c:317:11: note: to match this '(' > (void *(* _Nonnull)(void *))&txworker_sm, > ^ > 1 error generated. > *** [tx.o] Error code 1 > > I have a small Makefile patch I'll send as a pull request to satisfy > portlint. > > -- > > Thanks, > > Josh Paetzel > The nonnull attrib error is a thing to ponder nice to save those two instructions: http://rachid.koucha.free.fr/tech_corner/nonnull_gcc_attribute.html. Looks like we got it here https://reviews.freebsd.org/D2101 And clang suggested a change that I complicitly copied without understanding the portability damage. What's the portable way to murder all the typing and shut up the compiler warnings? Is there a correct way to indicate the correct types through the pthreads interfaces? I'm also open to suggestions for a minimal makefile that satisfies the build discipline. The tool itself doesn't need anything except sockets and stdio. Future work would cap limit this, but it's not really portable yet. And thanks for the portlint PR while I learn the poudriere.