From owner-cvs-all@FreeBSD.ORG Mon Mar 12 18:56:49 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0770916A404; Mon, 12 Mar 2007 18:56:49 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id 887D713C43E; Mon, 12 Mar 2007 18:56:48 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 32683487F7; Mon, 12 Mar 2007 19:56:44 +0100 (CET) Received: from localhost (154.81.datacomsa.pl [195.34.81.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id E344145684; Mon, 12 Mar 2007 19:56:38 +0100 (CET) Date: Mon, 12 Mar 2007 19:56:38 +0100 From: Pawel Jakub Dawidek To: John Baldwin Message-ID: <20070312185638.GA5688@garage.freebsd.pl> References: <200703092241.l29Mf2Ds062856@repoman.freebsd.org> <3bbf2fe10703100344w1f2464f0q68086a5af7c4f63c@mail.gmail.com> <20070310205236.GA9185@garage.freebsd.pl> <200703121116.24667.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FCuugMFkClbJLl1L" Content-Disposition: inline In-Reply-To: <200703121116.24667.jhb@freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: Attilio Rao , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/share/man/man9 Makefile condvar.9 lock.9 mi_switch.9 mtx_pool.9 mutex.9 rwlock.9 sleep.9 sleepqueue.9 sx.9 thread_exit.9 src/sys/kern kern_synch.c src/sys/sys mutex.h rwlock.h sleepqueue.h sx.h systm.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2007 18:56:49 -0000 --FCuugMFkClbJLl1L Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 12, 2007 at 11:16:23AM -0400, John Baldwin wrote: > On Saturday 10 March 2007 15:52, Pawel Jakub Dawidek wrote: > > What about something like this: > >=20 > > #define cv_wait(cv, lock) do { > > switch (LO_CLASSINDEX((struct lock_object *)(lock))) { >=20 > The problem with a cast is you use type checking. Might as well do this: >=20 > #define cv_wait(cv, lock) _cv_wait((cv), (struct lock_object *)(lock)) This will skip type checking and my version only cast to provide type checking, so when you pass some random variable it will give you an error. > > PS. I'd really like to be able to use condvar(9) with sx(9) locks, > > because currently I've to manage mu own condvar(9) version for ZFS > > that does exactly this. >=20 > The patch is already done in //depot/jhb/lock/..., just need to settle on= the=20 > API. Ok, good. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --FCuugMFkClbJLl1L Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFF9aJmForvXbEpPzQRAkW7AKCBnAg3YjjeGIne/iow2TAJV32NkQCgphsJ S3+SEb/81cQTv+m4qqT/KJI= =mMT0 -----END PGP SIGNATURE----- --FCuugMFkClbJLl1L--