From owner-freebsd-fs Wed Nov 20 21:25:24 2002 Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1DE8E37B401 for ; Wed, 20 Nov 2002 21:25:23 -0800 (PST) Received: from beastie.mckusick.com (beastie.mckusick.com [209.31.233.184]) by mx1.FreeBSD.org (Postfix) with ESMTP id CEC2643E42 for ; Wed, 20 Nov 2002 21:25:21 -0800 (PST) (envelope-from mckusick@beastie.mckusick.com) Received: from beastie.mckusick.com (localhost [127.0.0.1]) by beastie.mckusick.com (8.12.3/8.12.3) with ESMTP id gAL5PG59058300; Wed, 20 Nov 2002 21:25:16 -0800 (PST) (envelope-from mckusick@beastie.mckusick.com) Message-Id: <200211210525.gAL5PG59058300@beastie.mckusick.com> To: Alfred Perlstein Subject: Re: snapshots+dump/restore Cc: fs@freebsd.org, Poul-Henning Kamp In-Reply-To: Your message of "Mon, 04 Nov 2002 00:34:53 PST." <20021104083453.GR24139@elvis.mu.org> Date: Wed, 20 Nov 2002 21:25:16 -0800 From: Kirk McKusick Sender: owner-freebsd-fs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Date: Mon, 4 Nov 2002 00:34:53 -0800 From: Alfred Perlstein To: fs@freebsd.org Cc: Kirk McKusick , Poul-Henning Kamp Subject: snapshots+dump/restore I'm cc'ing the those most involved with the current code. When taking a dump(8) on a ufs filesystem with a snapshot node the dump grabs the snapshot file and trys to dump it, shouldn't some flag or something be set on the file that tells dump(8) to skip over it? If the semantics can be agreed on I can take a shot at implementing a fix/workaround/whatever. I particularly think that dump should _never_ try to grab a .fsck_snapshot file. Comments/suggestions? -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' You are correct. Dump should never try to dump a snapshot. Rather it should just put the inode on the tape as a zero length regular file (much as snapshots do if you try to look at other snapshots contained within them). You cannot just skip the inode entirely because that would require you to find all the directory entries that point at that inode and delete them which would be a lot more work). I have added the skipping over of snapshot inodes in dump to my TODO list. Kirk McKusick To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-fs" in the body of the message