Date: Tue, 12 Jan 1999 11:21:31 -0800 From: Mike Smith <mike@smith.net.au> To: Eivind Eklund <eivind@FreeBSD.ORG> Cc: Luigi Rizzo <luigi@labinfo.iet.unipi.it>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet ip_input.c Message-ID: <199901121921.LAA05046@dingo.cdrom.com> In-Reply-To: Your message of "Tue, 12 Jan 1999 14:35:51 %2B0100." <19990112143551.D65459@bitbox.follo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Tue, Jan 12, 1999 at 12:17:22PM +0100, Luigi Rizzo wrote: > > > Modified files: > > > sys/netinet ip_input.c > > > Log: > > > Add #ifdef's to avoid unused label warning in some cases. > > > > i wonder if it is preferable to clutter the code with #ifdef's or > > tolerate the potential warnings. > > Unless good counter-arguments spring forward, -Werror is going in > shortly, so tolerating the warnings is not an option. -Werror is anal fluff. I applaud it being the default for general usage, but -Werror made working on NetBSD *extremely* difficult. Stamping out warnings is desirable, but sometimes the crud in the code required to do it is worse than the warning. > This is because people otherwise ignore their warnings, and this make > it difficult to use the warnings to remove true bugs (of which I've > found at least 3 during this round of commits). Indeed. Committed code should (MHO) compile with -Werror, but it should be very clear how to turn it off (eg. /etc/make.conf). -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901121921.LAA05046>