From owner-svn-src-head@FreeBSD.ORG Wed Sep 3 19:10:36 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1CFF3BF4; Wed, 3 Sep 2014 19:10:36 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "funkthat.com", Issuer "funkthat.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CFCB815A9; Wed, 3 Sep 2014 19:10:35 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id s83JASJb082101 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 3 Sep 2014 12:10:29 -0700 (PDT) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id s83JASop082100; Wed, 3 Sep 2014 12:10:28 -0700 (PDT) (envelope-from jmg) Date: Wed, 3 Sep 2014 12:10:28 -0700 From: John-Mark Gurney To: Gleb Smirnoff Subject: Re: svn commit: r270999 - head/sys/kern Message-ID: <20140903191028.GG71691@funkthat.com> References: <201409030814.s838E7A2084257@svn.freebsd.org> <20140903085523.GB13871@dft-labs.eu> <20140903094916.GO7693@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140903094916.GO7693@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Wed, 03 Sep 2014 12:10:29 -0700 (PDT) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Mateusz Guzik , kib@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Sep 2014 19:10:36 -0000 Gleb Smirnoff wrote this message on Wed, Sep 03, 2014 at 13:49 +0400: > Mateusz, Kostik, > > On Wed, Sep 03, 2014 at 10:55:23AM +0200, Mateusz Guzik wrote: > M> > Modified: head/sys/kern/kern_proc.c > M> > ============================================================================== > M> > --- head/sys/kern/kern_proc.c Wed Sep 3 08:13:46 2014 (r270998) > M> > +++ head/sys/kern/kern_proc.c Wed Sep 3 08:14:07 2014 (r270999) > M> > @@ -921,10 +921,11 @@ fill_kinfo_proc_only(struct proc *p, str > M> > kp->ki_xstat = p->p_xstat; > M> > kp->ki_acflag = p->p_acflag; > M> > kp->ki_lock = p->p_lock; > M> > - if (p->p_pptr) > M> > + if (p->p_pptr) { > M> > kp->ki_ppid = proc_realparent(p)->p_pid; > M> > - if (p->p_flag & P_TRACED) > M> > - kp->ki_tracer = p->p_pptr->p_pid; > M> > + if (p->p_flag & P_TRACED) > M> > + kp->ki_tracer = p->p_pptr->p_pid; > M> > + } > M> > } > M> > > M> > /* > M> > > M> > M> p_pptr must be non-NULL if P_TRACED is set. If there is no way to > M> annotate it for coverity, this change deserves a comment in the code > M> (and in retrospect previous code should have had appropriate comment as > M> well). > > Thanks for explanation. > > I'd suggest to leave the change in, since now it is a micro-micro-optimization :) If you must leave it in, then at least compare the pointer against NULL, and collapse two if statements into one... We should never introduce new pointer checks that aren't against NULL... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."