From owner-p4-projects@FreeBSD.ORG  Fri Dec  1 03:22:41 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id DB50816A415; Fri,  1 Dec 2006 03:22:40 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id AF1B316A403
	for <perforce@freebsd.org>; Fri,  1 Dec 2006 03:22:40 +0000 (UTC)
	(envelope-from scottl@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DDA4C43CA8
	for <perforce@freebsd.org>; Fri,  1 Dec 2006 03:22:28 +0000 (GMT)
	(envelope-from scottl@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kB13MerS043928
	for <perforce@freebsd.org>; Fri, 1 Dec 2006 03:22:40 GMT
	(envelope-from scottl@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kB13MdBB043924
	for perforce@freebsd.org; Fri, 1 Dec 2006 03:22:39 GMT
	(envelope-from scottl@freebsd.org)
Date: Fri, 1 Dec 2006 03:22:39 GMT
Message-Id: <200612010322.kB13MdBB043924@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	scottl@freebsd.org using -f
From: Scott Long <scottl@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 110779 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Dec 2006 03:22:41 -0000

http://perforce.freebsd.org/chv.cgi?CH=110779

Change 110779 by scottl@scottl-x64 on 2006/12/01 03:22:04

	Fix a possible leaked lock.

Affected files ...

.. //depot/projects/scottl-camlock/src/sys/cam/cam_xpt.c#47 edit

Differences ...

==== //depot/projects/scottl-camlock/src/sys/cam/cam_xpt.c#47 (text+ko) ====

@@ -2577,9 +2577,9 @@
 		mtx_unlock(&xsoftc.xpt_lock);
 		mtx_lock(bus->sim->mtx);
 		retval = tr_func(bus, arg);
+		mtx_unlock(bus->sim->mtx);
 		if (retval == 0)
 			return(retval);
-		mtx_unlock(bus->sim->mtx);
 		mtx_lock(&xsoftc.xpt_lock);
 	}
 	mtx_unlock(&xsoftc.xpt_lock);