From owner-svn-ports-head@FreeBSD.ORG Tue Feb 12 13:10:21 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D8DAC9CD; Tue, 12 Feb 2013 13:10:21 +0000 (UTC) (envelope-from miwi.freebsd@gmail.com) Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by mx1.freebsd.org (Postfix) with ESMTP id A668AE2E; Tue, 12 Feb 2013 13:10:21 +0000 (UTC) Received: by mail-pa0-f48.google.com with SMTP id hz10so82663pad.7 for ; Tue, 12 Feb 2013 05:10:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to:x-mailer; bh=TfagAh14eeP8lq/E1f9hW20o7aAUfJyfFPg1IPJYuRA=; b=VxKMRAd6MXshUU+ce+1EOWzkhbf/bpFXKHtxdvtiU4pzRRnWmCLBpmu6s1kiysQR2x qepnNxqiq+SraMiXykpvWQWu0c6oUi3s+0DHCgzU/MJIOHg55sWs5R0zw85YsGDQn0Ad aTHAO/d5tgTkIFehFIRqU9aAsR+xUhMvql79y44nLssPZmMaUfy0pD55v8QkPt5G1lX7 kkHv6C66R7LpVG3LKyErPEMotdeFWMOb3js+qP+SmUUk/B6vvQ6H4v1Fl/CvC++Z8Zod 44ngF8PdjHpB4kY5A4HQlEKzXiCgTeNCCSyndEzS0TzQGZg/d28wor179m6QtMDB92bg SWgg== X-Received: by 10.66.52.50 with SMTP id q18mr52488267pao.16.1360674621075; Tue, 12 Feb 2013 05:10:21 -0800 (PST) Received: from [192.168.0.105] ([60.51.103.185]) by mx.google.com with ESMTPS id w2sm69517915pax.22.2013.02.12.05.10.17 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 12 Feb 2013 05:10:19 -0800 (PST) Sender: Martin Wilke Content-Type: text/plain; charset=koi8-r Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\)) Subject: Re: svn commit: r312091 - in head/audio: . gtmixer From: Martin Wilke In-Reply-To: <20130212122832.GA82139@FreeBSD.org> Date: Tue, 12 Feb 2013 21:10:16 +0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201302121005.r1CA5iJj080078@svn.freebsd.org> <20130212122832.GA82139@FreeBSD.org> To: Alexey Dokuchaev X-Mailer: Apple Mail (2.1499) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2013 13:10:21 -0000 All your comments fixed except from the grammar feel free to fix it. - Martin +-----------------oOO--(_)--OOo-------------------------+ With best Regards, Martin Wilke (miwi_(at)_FreeBSD.org) Mess with the Best, Die like the Rest On Feb 12, 2013, at 8:28 PM, Alexey Dokuchaev wrote: > On Tue, Feb 12, 2013 at 10:05:44AM +0000, Martin Wilke wrote: >> New Revision: 312091 >> URL: http://svnweb.freebsd.org/changeset/ports/312091 >>=20 >> +PORTNAME=3D gtmixer >> +PORTVERSION=3D 1.0.2 >> +CATEGORIES=3D audio >> +MASTER_SITES=3D http://github.com/svagner/gtmixer/archive/ >> +DISTNAME=3D ${PORTVERSION} >=20 > Perhaps USE_GITHUB could be used here?.. >=20 >> +WRKSRC=3D ${WRKDIR}/${PORTNAME}-${PORTVERSION} >> +FETCH_ARGS=3D -Fpr >=20 > ... which could also release you from setting FETCH_ARGS. (Setting = WRKSRC > also looks weird, but I'm not sure yet if it can be omitted.) >=20 >> +do-install: >> + @${MKDIR} ${PREFIX}/share/gtmixer >> + @${CP} -r ${WRKSRC}/icons ${PREFIX}/share/gtmixer/ >> + @${INSTALL_MAN} ${WRKSRC}/gtmixer.1 ${MAN1PREFIX}/man/man1 >=20 > We do not mute installation commands (muting MKDIR is fine). >=20 >> +++ head/audio/gtmixer/pkg-descr Tue Feb 12 10:05:43 2013 = (r312091) >> @@ -0,0 +1,4 @@ >> +GTMixer is a free, simple graphical mixer for FreeBSD. >> +Based at GTK 2.0 Lib. >=20 > Bad grammar, bogus use of contraction and capitalization; also it = seems port > description could be augmented a bit. >=20 > ./danfe