From owner-svn-src-head@FreeBSD.ORG  Tue Nov  5 19:49:53 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id A65085F7;
 Tue,  5 Nov 2013 19:49:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9251C21DF;
 Tue,  5 Nov 2013 19:49:53 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id rA5JnrvY013301;
 Tue, 5 Nov 2013 19:49:53 GMT (envelope-from jhb@svn.freebsd.org)
Received: (from jhb@localhost)
 by svn.freebsd.org (8.14.7/8.14.5/Submit) id rA5Jnr1c013300;
 Tue, 5 Nov 2013 19:49:53 GMT (envelope-from jhb@svn.freebsd.org)
Message-Id: <201311051949.rA5Jnr1c013300@svn.freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Date: Tue, 5 Nov 2013 19:49:53 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r257715 - head/etc
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Nov 2013 19:49:53 -0000

Author: jhb
Date: Tue Nov  5 19:49:53 2013
New Revision: 257715
URL: http://svnweb.freebsd.org/changeset/base/257715

Log:
  Don't explicitly invoke ifn_start on new child interfaces (vaps and
  subinterfaces) after they are created.  Interfaces are already started
  by devd invoking /etc/pccard_ether when they are created, so the explicit
  calls in childif_create() resulted in interfaces being started twice.
  
  Note that interfaces created via cloned_interfaces are not explicitly
  started but depend on the devd mechanism already.
  
  MFC after:	1 week

Modified:
  head/etc/network.subr

Modified: head/etc/network.subr
==============================================================================
--- head/etc/network.subr	Tue Nov  5 19:40:34 2013	(r257714)
+++ head/etc/network.subr	Tue Nov  5 19:49:53 2013	(r257715)
@@ -1429,9 +1429,6 @@ childif_create()
 			fi
 			${IFCONFIG_CMD} $i name $child && cfg=0
 		fi
-		if autoif $child; then
-			ifn_start $child
-		fi
 	done
 
 	# Create vlan interfaces
@@ -1455,9 +1452,6 @@ childif_create()
 				${IFCONFIG_CMD} $i name $child && cfg=0
 			fi
 		fi
-		if autoif $child; then
-			ifn_start $child
-		fi
 	done
 
 	return ${cfg}