From owner-dev-commits-src-main@freebsd.org Thu Aug 5 16:52:21 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 801EF6669BA; Thu, 5 Aug 2021 16:52:21 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4GgZQs2rjLz3NqF; Thu, 5 Aug 2021 16:52:21 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from [192.168.1.2] (pool-74-110-137-7.rcmdva.fios.verizon.net [74.110.137.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: gallatin) by duke.cs.duke.edu (Postfix) with ESMTPSA id 4DFF12700137; Thu, 5 Aug 2021 12:52:15 -0400 (EDT) DMARC-Filter: OpenDMARC Filter v1.3.1 duke.cs.duke.edu 4DFF12700137 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cs.duke.edu; s=mail0816; t=1628182335; bh=Ksg4Hdvv9K4OMkSjrReb686FZ2ippIK4LIHBjpjwwEY=; h=Subject:To:From:Date:From; b=EwGDRwIyvH2Awm1edHGwfrmkQBQSLTLd0CgC1lJxx1Z5VILWLjWnalXNpAR5wEsou 1I7l9YHrmaU3qsFyoGyOJ+sVTuSvoVTOJu0k323GmmhO9Xw5s+LY3+mTzYC4BGorCp rjFStkt8/UxfyhLlccodzzA04pX1eV37rTKeeLfcadSlgnwKXwPJqDuQWSQdZesD8I ShjLezPl0spJNNWrQzfatDYcXH01NJY3QylBnV+3Dc7QsDkmuHYmlC35KtPoLsFvyv LoQizmUJMmUH1QaIHJKe9I8lhWvahhHnn3G79a9LgVvK6N3UaE61AsJywHSHNGU7pC 3YmtD1Zn6zI1A== Subject: Re: git: 98215005b747 - main - ktls: start a thread to keep the 16k ktls buffer zone populated To: Ed Maste , Andrew Gallatin Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202108051422.175EMBpP006556@gitrepo.freebsd.org> From: Andrew Gallatin Message-ID: Date: Thu, 5 Aug 2021 12:52:14 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4GgZQs2rjLz3NqF X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Aug 2021 16:52:21 -0000 On 8/5/21 11:59 AM, Ed Maste wrote: > On Thu, 5 Aug 2021 at 10:22, Andrew Gallatin wrote: >> >> The branch main has been updated by gallatin: >> >> URL: https://urldefense.com/v3/__https://cgit.FreeBSD.org/src/commit/?id=98215005b747fef67f44794ca64abd473b98bade__;!!OToaGQ!6H22s_lcYmkhuynvYHpkyGHe143j9dOq8CYazaDqtTi9kyapeu9DMyf0Tvo0tDDCVw$ >> >> commit 98215005b747fef67f44794ca64abd473b98bade >> Author: Andrew Gallatin >> AuthorDate: 2021-08-05 14:15:09 +0000 >> Commit: Andrew Gallatin >> CommitDate: 2021-08-05 14:19:12 +0000 >> >> ktls: start a thread to keep the 16k ktls buffer zone populated > > My Cirrus-CI boot smoke test is now failing with: > > Starting KTLS alloc thread for domain 0 > panic: sleeping without a lock > cpuid = 0 > time = 1 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe0000b20ae0 > vpanic() at vpanic+0x187/frame 0xfffffe0000b20b40 > panic() at panic+0x43/frame 0xfffffe0000b20ba0 > _sleep() at _sleep+0x484/frame 0xfffffe0000b20c40 > ktls_alloc_thread() at ktls_alloc_thread+0x1c4/frame 0xfffffe0000b20cf0 > fork_exit() at fork_exit+0x80/frame 0xfffffe0000b20d30 > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0000b20d30 > --- trap 0, rip = 0, rsp = 0, rbp = 0 --- > KDB: enter: panic > [ thread pid 2 tid 100027 ] > Stopped at kdb_enter+0x37: movq $0,0x127877e(%rip) > db> qemu-system-x86_64: terminating on signal 15 from pid 32579 (timeout) > Did not boot successfully, see /tmp/ci-qemu-test-boot.log > I'd thought that I'd tested this with INVARIANTS, but I guess I was wrong. The assert is failing because I'm sleeping forever (sbt == 0). I don't understand the point of the assert, but I've reproduced the panic and am testing a workaround. Drew