From owner-freebsd-current@FreeBSD.ORG Mon Mar 29 22:05:14 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3D3EF106564A; Mon, 29 Mar 2010 22:05:14 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-jnhn.mail.uoguelph.ca (esa-jnhn.mail.uoguelph.ca [131.104.91.44]) by mx1.freebsd.org (Postfix) with ESMTP id CBBB88FC08; Mon, 29 Mar 2010 22:05:13 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAHTAsEuDaFvI/2dsb2JhbACbJ3HAEIUBBA X-IronPort-AV: E=Sophos;i="4.51,330,1267419600"; d="scan'208";a="70402685" Received: from darling.cs.uoguelph.ca ([131.104.91.200]) by esa-jnhn-pri.mail.uoguelph.ca with ESMTP; 29 Mar 2010 18:05:13 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by darling.cs.uoguelph.ca (Postfix) with ESMTP id 194519400EA; Mon, 29 Mar 2010 18:05:13 -0400 (EDT) X-Virus-Scanned: amavisd-new at darling.cs.uoguelph.ca Received: from darling.cs.uoguelph.ca ([127.0.0.1]) by localhost (darling.cs.uoguelph.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id akz6Sy4odI47; Mon, 29 Mar 2010 18:05:12 -0400 (EDT) Received: from muncher.cs.uoguelph.ca (muncher.cs.uoguelph.ca [131.104.91.102]) by darling.cs.uoguelph.ca (Postfix) with ESMTP id A36E59400DA; Mon, 29 Mar 2010 18:05:12 -0400 (EDT) Received: from localhost (rmacklem@localhost) by muncher.cs.uoguelph.ca (8.11.7p3+Sun/8.11.6) with ESMTP id o2TMIS316443; Mon, 29 Mar 2010 18:18:28 -0400 (EDT) X-Authentication-Warning: muncher.cs.uoguelph.ca: rmacklem owned process doing -bs Date: Mon, 29 Mar 2010 18:18:28 -0400 (EDT) From: Rick Macklem X-X-Sender: rmacklem@muncher.cs.uoguelph.ca To: John Baldwin In-Reply-To: <201003291216.23887.jhb@freebsd.org> Message-ID: References: <20100326162406.GA43912@fit.vutbr.cz> <201003291216.23887.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Petr Lampa , freebsd-current@freebsd.org Subject: Re: Possible error in nfs_nfsdserv.c? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Mar 2010 22:05:14 -0000 On Mon, 29 Mar 2010, John Baldwin wrote: >> >> I've cc'd freebsd-current, so that anyone conversant with the FreeBSD >> VFS can jump in here. Am I right to assume that VOP_LOOKUP() for CREATE >> will set SAVENAME when returning error == 0? > > No, the caller has to set that flag. Some filesystems set it internally to > force the name to be saved (e.g. the NFS client), but there is nothing in the > VFS layer itself that sets it that I can see. > Thanks John. I spotted the comment in vfs_lookup.c that basically said that, this morning. I'll fix up the experimental server soon, although it seems that ufs and zfs usually set SAVENAME for the CREATE cases, which is why I've never seen the panic. rick