From owner-dev-commits-src-main@freebsd.org Wed Sep 8 01:32:34 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 34DD36723D3; Wed, 8 Sep 2021 01:32:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4H44Ps6Ynwz3Gvb; Wed, 8 Sep 2021 01:32:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8BD891D344; Wed, 8 Sep 2021 01:32:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1881WXC5069849; Wed, 8 Sep 2021 01:32:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1881WXPv069848; Wed, 8 Sep 2021 01:32:33 GMT (envelope-from git) Date: Wed, 8 Sep 2021 01:32:33 GMT Message-Id: <202109080132.1881WXPv069848@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Colin Percival Subject: git: a8b89dff6ac0 - main - Disable acpi_timer_test by default MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a8b89dff6ac026e60983824889d3666842ff409b Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Sep 2021 01:32:34 -0000 The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=a8b89dff6ac026e60983824889d3666842ff409b commit a8b89dff6ac026e60983824889d3666842ff409b Author: Colin Percival AuthorDate: 2021-09-07 23:59:45 +0000 Commit: Colin Percival CommitDate: 2021-09-08 01:31:55 +0000 Disable acpi_timer_test by default This disables testing the ACPI timer by default, forcing the use of ACPI-fast rather than ACPI-safe. The broken-ACPI-timers workaround can be re-enabled by setting the hw.acpi.timer_test_enabled=1 tunable. This speeds up the FreeBSD boot process by 140 ms on an EC2 c5.xlarge instance. This change will not be MFCed. Assuming no problems are reported, acpi_timer_test, the associated tunable, and the ACPI-safe timecounter should be removed in FreeBSD 15. Relnotes: The ACPI-safe timer is disabled in favour of ACPI-fast; if timekeeping issues are observed, please test with hw.acpi.timer_test_enabled=1 in loader.conf and report if that fixes the problem. --- sys/dev/acpica/acpi_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/acpica/acpi_timer.c b/sys/dev/acpica/acpi_timer.c index 8be6e0edea7f..8e3947709b61 100644 --- a/sys/dev/acpica/acpi_timer.c +++ b/sys/dev/acpica/acpi_timer.c @@ -79,7 +79,7 @@ static int acpi_timer_sysctl_freq(SYSCTL_HANDLER_ARGS); static void acpi_timer_boot_test(void); static int acpi_timer_test(void); -static int acpi_timer_test_enabled = 1; +static int acpi_timer_test_enabled = 0; TUNABLE_INT("hw.acpi.timer_test_enabled", &acpi_timer_test_enabled); static device_method_t acpi_timer_methods[] = {