From owner-svn-ports-head@freebsd.org Sun Oct 4 02:48:32 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BCFA3A0E6C7; Sun, 4 Oct 2015 02:48:32 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pa0-x234.google.com (mail-pa0-x234.google.com [IPv6:2607:f8b0:400e:c03::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9595913A9; Sun, 4 Oct 2015 02:48:32 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by pacex6 with SMTP id ex6so142214652pac.0; Sat, 03 Oct 2015 19:48:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:references:to:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=AVhxi1O7lH/PU0CBMluV2JVcM7KHzbM3qGCkEJSrjHA=; b=JBoic+RlvHUqB/Y0MTCE4592SiEt4ITKH6Qt/+qp1ADh+ZM6ZI5NflJvA5dQtjtu2S OPCDM+QKs4zTOympYpuH0nXc/YsO1EvddzUk7BuOaSFgX1rhkrOJtArI2e8SpViCCyKU aPZB6rcQ4Bih8hOAsvy/yUqu26IpglGaG/IFOyLKKIk8Ank/2U/b+ViocuhNyW+Erdy/ TuS6c0fMJG0cPeXKPV8i4VRMncMmpjZ5NTER8HRplbhXfBDVztL3lWcRHEQ2lWUJ4ctx pGtGY70Bq/DEOybwJZz+x1ihE8Ib76EE0M0c6cpOMKQca+GRs8Ijcxm+bnmRGfsJl7eA C55g== X-Received: by 10.68.219.133 with SMTP id po5mr30305663pbc.135.1443926911895; Sat, 03 Oct 2015 19:48:31 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01::8? (2001-44b8-31ae-7b01-0000-0000-0000-0008.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01::8]) by smtp.gmail.com with ESMTPSA id ip1sm19820199pbc.30.2015.10.03.19.48.29 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Oct 2015 19:48:31 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r398482 - head/devel/py-greenlet References: <201510031707.t93H7UBs008407@repo.freebsd.org> To: Sunpoet Po-Chuan Hsieh , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Dmitry Marakasov From: Kubilay Kocak X-Enigmail-Draft-Status: N1110 Message-ID: <5610937B.1000708@FreeBSD.org> Date: Sun, 4 Oct 2015 13:48:27 +1100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101 Thunderbird/41.0 MIME-Version: 1.0 In-Reply-To: <201510031707.t93H7UBs008407@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Oct 2015 02:48:32 -0000 On 4/10/2015 4:07 AM, Sunpoet Po-Chuan Hsieh wrote: > Author: sunpoet > Date: Sat Oct 3 17:07:29 2015 > New Revision: 398482 > URL: https://svnweb.freebsd.org/changeset/ports/398482 > > Log: > - Convert to new test framework > > Modified: > head/devel/py-greenlet/Makefile > > Modified: head/devel/py-greenlet/Makefile > ============================================================================== > --- head/devel/py-greenlet/Makefile Sat Oct 3 17:07:24 2015 (r398481) > +++ head/devel/py-greenlet/Makefile Sat Oct 3 17:07:29 2015 (r398482) > @@ -12,14 +12,13 @@ COMMENT= Light-weight microthreads for P > > LICENSE= MIT > > +DO_MAKE_TEST= ${PYTHON_CMD} This is horrible & super ugly. Why can't we have / isn't there a TEST_CMD variable to complement TEST_{ARGS,DEPENDS,*} variables? The new test framework is VERY VERY welcome, but I'm worried it needs polishing/refinement for extensibility across the broader ports framework *before* a large number of ports have been 'converted', thereby cementing in an under-baked implementation and making it much harder to change for the better. Another worry is that there isn't an *explicit* opt-in or toggle to enable tests. It is imperative to have a way to enable/disable test mechanisms independently to whether TEST_DEPENDS and other variables are defined or not. CC'ing Dmitry for more feedback. > ONLY_FOR_ARCHS= amd64 i386 > +TEST_TARGET= run-tests.py > USE_PYTHON= autoplist concurrent distutils > USES= python > > post-install: > ${STRIP_CMD} ${STAGEDIR}${PYTHON_SITELIBDIR}/greenlet.so > > -regression-test test: build > - cd ${WRKSRC}/ && ${PYTHON_CMD} run-tests.py > - > .include >