From owner-cvs-doc@FreeBSD.ORG Mon Jul 16 14:29:43 2007 Return-Path: X-Original-To: cvs-doc@FreeBSD.org Delivered-To: cvs-doc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 110C916A400; Mon, 16 Jul 2007 14:29:43 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from postfix1-g20.free.fr (postfix1-g20.free.fr [212.27.60.42]) by mx1.freebsd.org (Postfix) with ESMTP id BD94813C4D9; Mon, 16 Jul 2007 14:29:41 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp6-g19.free.fr (smtp6-g19.free.fr [212.27.42.36]) by postfix1-g20.free.fr (Postfix) with ESMTP id 44A17166F296; Mon, 16 Jul 2007 16:11:14 +0200 (CEST) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by smtp6-g19.free.fr (Postfix) with ESMTP id E8AE4B7BB5; Mon, 16 Jul 2007 16:11:12 +0200 (CEST) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 40D6B120FC; Mon, 16 Jul 2007 16:11:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at xbsd.org Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n1GGZI3VqitN; Mon, 16 Jul 2007 16:11:06 +0200 (CEST) Received: from [193.95.134.156] (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id A5B1611D7E; Mon, 16 Jul 2007 16:11:05 +0200 (CEST) Message-ID: <469B7CE0.8030409@FreeBSD.org> Date: Mon, 16 Jul 2007 15:12:48 +0100 From: Florent Thoumie User-Agent: Thunderbird 1.5.0.9 (X11/20070122) MIME-Version: 1.0 To: Chin-San Huang , cvs-doc@FreeBSD.org References: <20070716135602.7EF3816A49C@hub.freebsd.org> In-Reply-To: <20070716135602.7EF3816A49C@hub.freebsd.org> X-Enigmail-Version: 0.94.1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig8EF1B6389C63C203D9FA2F4D" Cc: Subject: Re: cvs commit: doc/en_US.ISO8859-1/books/arch-handbook/driverbasics chapter.sgml X-BeenThere: cvs-doc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the doc and www trees List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2007 14:29:43 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8EF1B6389C63C203D9FA2F4D Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Chin-San Huang wrote: > chinsan 2007-07-16 13:55:59 UTC >=20 > FreeBSD doc repository >=20 > Modified files: > en_US.ISO8859-1/books/arch-handbook/driverbasics chapter.sgml=20 > Log: > - According to the module(9) man page, the return value for > unrecognized values is EOPNOTSUPP, not EINVAL. > =20 > Noticed by: kevlo Using both EINVAL and EOPNOTSUPP makes sense to me. In the arch-handbook code snippet we return EOPNOTSUPP whether what is MOD_QUIESCE or an invalid value. I understand it's done that way for simplicity's sake (instead of adding a case statement for unsupported operations and default to return EINVAL), but there's an inconsistency with module(9). It currently says: "The module should return EOPNOTSUPP for unrecognized values of what" Maybe something like the following would be better: "The module should return EOPNOTSUPP for unsupported and unrecognized values of what." --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --------------enig8EF1B6389C63C203D9FA2F4D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGm3zlMxEkbVFH3PQRCoKpAKCHrnpoqbadhGjFAQ+9f36Q6tG8pwCfS9IB leVkXhAHpabEG5kvVFPimfw= =RP8I -----END PGP SIGNATURE----- --------------enig8EF1B6389C63C203D9FA2F4D--