From owner-freebsd-fs@FreeBSD.ORG Tue Jun 26 05:03:59 2007 Return-Path: X-Original-To: fs@freebsd.org Delivered-To: freebsd-fs@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C1F9816A41F for ; Tue, 26 Jun 2007 05:03:59 +0000 (UTC) (envelope-from howard0su@gmail.com) Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.182]) by mx1.freebsd.org (Postfix) with ESMTP id 8161213C4AD for ; Tue, 26 Jun 2007 05:03:59 +0000 (UTC) (envelope-from howard0su@gmail.com) Received: by py-out-1112.google.com with SMTP id u77so2277674pyb for ; Mon, 25 Jun 2007 22:03:59 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type; b=I4vjMHOP3yUE1KYkHwyYF5gk4QdEuyxT2d3msL9LqISL/8O6UKyHWWzYiF9ZfqKl1xqNwwYUm0EVAQHWm6AzvTiHRHlc6O9AEBEohuH2kygeU4242q71+sgTrRW5ktsaxEBcCgyHQo93Zf+4Szf/cgjjzesbVWtsLmzp8huajJs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type; b=BqSI+JkPzIUJ4+ef8k485LLf4Qt61W/CLb0m7XKZ8EvF8pNPuhyEF5YWw4KmlYpFeGD3DOlD4QTpHw768FTpNzuHmFIGWzQZrpHjwT58OYoX7G9w8Nxt95a615f6VYbPB++I/j0pvGxyR21BK1hugH9cC4DLuLMCLC1+qFNlWAM= Received: by 10.35.83.20 with SMTP id k20mr3670918pyl.1182834238816; Mon, 25 Jun 2007 22:03:58 -0700 (PDT) Received: by 10.35.81.5 with HTTP; Mon, 25 Jun 2007 22:03:58 -0700 (PDT) Message-ID: Date: Tue, 26 Jun 2007 13:03:58 +0800 From: "Howard Su" To: fs@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: old code cleanup?? related to mnt_maxsymlinklen X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2007 05:03:59 -0000 When I read ufs code, i found there are many places checking vp->v_mount->mnt_maxsymlinklen >0. Seems it is for back compactiblity. I am wondering if we can start to cleanup these stuffs. Some comments give the intention that the code is pretty old. /* 4.4 format directories support whiteout operations */ if (dvp->v_mount->mnt_maxsymlinklen > 0) /* true if old FS format...*/ #define OFSFMT(vp) ((vp)->v_mount->mnt_maxsymlinklen <= 0) -- -Howard