Date: Tue, 30 Nov 2010 07:54:21 -0800 From: Bakul Shah <bakul@bitblocks.com> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> Cc: freebsd-hackers@freebsd.org, Matthew Jacob <mj@feral.com> Subject: Re: find(1): Is this a bug or not? Message-ID: <20101130155421.6340C5B73@mail.bitblocks.com> In-Reply-To: Your message of "Tue, 30 Nov 2010 12:33:54 %2B0100." <86zksrm4f1.fsf@ds4.des.no> References: <86r5e3zye4.fsf@pluton.xbsd.name> <4CF40F8F.30303@feral.com> <20101129221648.159C45B18@mail.bitblocks.com> <86zksrm4f1.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 30 Nov 2010 12:33:54 +0100 =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> wrote: > Bakul Shah <bakul@bitblocks.com> writes: > > Index: function.c > > --- function.c (revision 212707) > > +++ function.c (working copy) > > @@ -560,7 +560,7 @@ > > empty = 1; > > dir = opendir(entry->fts_accpath); > > if (dir == NULL) > > - err(1, "%s", entry->fts_accpath); > > + return 0; > > for (dp = readdir(dir); dp; dp = readdir(dir)) > > if (dp->d_name[0] != '.' || > > (dp->d_name[1] != '\0' && > > You should replace the err() call with a warn() call instead of removing > it outright. That would print the err msg twice as opendir (or something) already seems to report the error. Try it!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101130155421.6340C5B73>