From owner-freebsd-scsi@FreeBSD.ORG  Wed Feb 28 23:24:00 2007
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
X-Original-To: freebsd-scsi@freebsd.org
Delivered-To: freebsd-scsi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 2156516A405
	for <freebsd-scsi@freebsd.org>; Wed, 28 Feb 2007 23:24:00 +0000 (UTC)
	(envelope-from thomas@FreeBSD.ORG)
Received: from melamine.cuivre.fr.eu.org (melusine.cuivre.fr.eu.org
	[82.225.155.84])
	by mx1.freebsd.org (Postfix) with ESMTP id DF3A613C49D
	for <freebsd-scsi@freebsd.org>; Wed, 28 Feb 2007 23:23:59 +0000 (UTC)
	(envelope-from thomas@FreeBSD.ORG)
Received: by melamine.cuivre.fr.eu.org (Postfix, from userid 1000)
	id 4C04F5C147; Thu,  1 Mar 2007 00:03:39 +0100 (CET)
Date: Thu, 1 Mar 2007 00:03:39 +0100
From: Thomas Quinot <thomas@FreeBSD.ORG>
To: Scott Long <scottl@samsco.org>
Message-ID: <20070228230339.GA77452@melamine.cuivre.fr.eu.org>
References: <20070225193802.GA32605@melamine.cuivre.fr.eu.org>
	<45E5F730.5070900@samsco.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <45E5F730.5070900@samsco.org>
X-message-flag: WARNING! Using Outlook can damage your computer.
User-Agent: Mutt/1.5.11
Cc: freebsd-scsi@freebsd.org
Subject: Re: xpt_done() and Giant?
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Feb 2007 23:24:00 -0000

* Scott Long, 2007-02-28 :

> I overlooked this, sorry.  Can you survive with it as it is for now?

Well, the current situation has been current for quite some time, so I
think I can survive it :-)

On the other hand, the ATAPI/CAM interrupt routine runs outside of Giant
and calls xpt_done (and also calls CAM_DEBUGGED itself), and it would be
nice if CAMDEBUG worked with it. Is there any compelling reason for
having GIANT_REQUIRED in xpt_path_comp? The only case I can see this as
useful is when called in the context of CAM_DEBUG or CAM_DEBUGGED, to
protect against a concurrent update of cam_dpath, but this really looks
to me like a really tiny corner case.

Thomas.