From owner-cvs-all@FreeBSD.ORG Tue Oct 25 05:49:41 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A3E3016A41F; Tue, 25 Oct 2005 05:49:41 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5347943D45; Tue, 25 Oct 2005 05:49:41 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.4/8.13.4) with ESMTP id j9P5nd7e068159; Mon, 24 Oct 2005 22:49:39 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.4/8.13.1/Submit) id j9P5narG068158; Mon, 24 Oct 2005 22:49:36 -0700 (PDT) (envelope-from obrien) Date: Mon, 24 Oct 2005 22:49:35 -0700 From: "David O'Brien" To: Scott Long Message-ID: <20051025054935.GH55418@dragon.NUXI.org> References: <200510240440.j9O4ecBQ063762@repoman.freebsd.org> <435D0798.2090306@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <435D0798.2090306@samsco.org> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.pre.mk X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Oct 2005 05:49:41 -0000 On Mon, Oct 24, 2005 at 10:11:04AM -0600, Scott Long wrote: > David E. O'Brien wrote: > >obrien 2005-10-24 04:40:38 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/conf kern.pre.mk > > Log: > > We no longer need INCLUDES+= -I$S/contrib/dev/acpica. > > > > Revision Changes Path > > 1.73 +2 -5 src/sys/conf/kern.pre.mk > > Why is this so important? Why is it worth conflicts with vendor code? How does it conflict with vendor code? See the recient archives of why it is wrong to have -I's in kern.pre.mk and how it only started in BSD .mk files when msmith imported acpica (Makefile.i386 rev 2.111). [only to later start mundging the files before importing them.] Warner also seems to have thought it wasn't good to polute the build of all files with global -I's: RCS file: /home/ncvs/src/sys/conf/Makefile.i386,v .. revision 1.265 date: 2005/04/13 14:49:57; author: imp; state: Exp; lines: +0 -2 .. Also, move the -I stuff to the centralized kern.pre.mk. However, it might be better to add these flags to files.conf. .. -- -- David (obrien@FreeBSD.org)