From owner-freebsd-current@FreeBSD.ORG Tue Oct 2 21:34:10 2007 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AE79916A420 for ; Tue, 2 Oct 2007 21:34:10 +0000 (UTC) (envelope-from minimarmot@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.242]) by mx1.freebsd.org (Postfix) with ESMTP id 6563B13C469 for ; Tue, 2 Oct 2007 21:34:10 +0000 (UTC) (envelope-from minimarmot@gmail.com) Received: by an-out-0708.google.com with SMTP id c14so887145anc for ; Tue, 02 Oct 2007 14:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=oyQxPMUDHqfJgoKatylGpgp7ORyZHU8hADglu3ZFwKA=; b=Z1yKKVOrxav1dxbIWuPALnKdUG7FVpzxoTd1JwqnMtN8khdQyWsgS1B/sALXHme+tygxKXWLPCsP35NXL+Y2syvt2er86Y69O2BhRU9aARpYpMK+CnLefS/4J/VERtCJZugHXona6Iuo8aMI7DI0TTjoToQSBoLHSlB/IfmxiVo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=biHu0bxlucS00tOPejViHRtD4O16tms4mCKnt52fHKC5SsNWj81NqVby2/cCA1LXgqk2lqzG+9aI3HvXgseldLX5L/8hJA9gL1BTMe0dxQXKwhbZDg6/g34n3hiJtJ9DxC8P7e1jGzEIuoTQT6zQIFJc0QHgg0xzpRwhx1Fwxyg= Received: by 10.142.158.17 with SMTP id g17mr216780wfe.1191359355553; Tue, 02 Oct 2007 14:09:15 -0700 (PDT) Received: by 10.143.14.9 with HTTP; Tue, 2 Oct 2007 14:09:15 -0700 (PDT) Message-ID: <47d0403c0710021409na4e8ba2p2005a11957bf4d28@mail.gmail.com> Date: Tue, 2 Oct 2007 17:09:15 -0400 From: "Ben Kaduk" To: "Craig Boston" , current@freebsd.org, danfe@freebsd.org In-Reply-To: <20071002204850.GA33227@nowhere> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070921202523.GB4044@nowhere> <20071002204850.GA33227@nowhere> Cc: Subject: Re: Patch for nvidia-driver on current (panic: spin locks can only use msleep_spin) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2007 21:34:10 -0000 Hi Craig, Thanks for tracking this down. However, mailman likes to eat non-MIME-text attachments. Thanks, Ben Kaduk On 10/2/07, Craig Boston wrote: > Hi all, I did some more investigating and found what was causing the > nvidia driver to occasionally panic on my machine. It calls cv_wait(9) > using a spin mutex, which according to the man page is a no-no. > > I simply changed the os_*_sema interfaces to use a standard mutex > instead. Tried running a bunch of glxgears and xscreensaver GL demos in > parallel and haven't been able to reproduce a panic since. As a bonus, > the 5 second pause I would sometimes get when a GL-based xscreensaver > process terminates seems to be gone as well. > > There doesn't appear to be any documentation that I could find as to > what contexts those functions may be called from. I'm not a locking > guru, so I can't say for certain why a spin mutex was being used. Wild > guess: an artifact from the 4.x or 5.x code that may be obsoleted by > adaptive mutexes. > > Patch is attached; cc danfe@ in case others report this problem to him. > > Craig > > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >