From owner-svn-src-head@freebsd.org Wed Apr 5 00:51:04 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BBE18D2CF14; Wed, 5 Apr 2017 00:51:04 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8313B869; Wed, 5 Apr 2017 00:51:04 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v350p3wC043386; Tue, 4 Apr 2017 17:51:03 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v350p3a4043385; Tue, 4 Apr 2017 17:51:03 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201704050051.v350p3a4043385@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r316477 - head/usr.bin/grep In-Reply-To: <9018c8db-2a89-c8b2-750b-fe11ac08333f@freebsd.org> To: Andrey Chernov Date: Tue, 4 Apr 2017 17:51:03 -0700 (PDT) CC: Kyle Evans , Ed Maste , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 00:51:04 -0000 > On 04.04.2017 15:24, Kyle Evans wrote: > > On Tue, Apr 4, 2017 at 7:07 AM, Andrey Chernov > > wrote: > > > > On 04.04.2017 2:16, Ed Maste wrote: > > > if (color) > > > - fprintf(stdout, "\33[m\33[K"); > > > + fprintf(stdout, "\33[00m\33[K"); > > > > Please back that one out. We don't need to handle internally or print > > remotely excessive 00. > > At least according to > > https://en.wikipedia.org/wiki/ANSI_escape_code > > > > "With no parameters, CSI m is treated as CSI 0 m (reset / normal), which > > is typical of most of the ANSI escape sequences." > > > > > > Hi ache@, > > > > This specific change was made in the name of explicitly matching colored > > output of GNU grep for simplification of regression test purposes, > > rather than for good form. Is it still unacceptable to do so? > > IMHO everyday usage by everyone weights much more than occasional > regression tests run which can be fixed instead of this place. F.e. we > already do a lot of local fixes in the NetBSD regression tests instead > of pretending to mimic NetBSD in 100% in the system itself. Also it might be worth making NetBSD aware of the bad output, and fix it there, and the regression test, and everyone well be better off. -- Rod Grimes rgrimes@freebsd.org