From nobody Thu Jan 25 05:07:36 2024 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TL8311mkGz57kdx for ; Thu, 25 Jan 2024 05:07:41 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TL8304YnLz4WR8; Thu, 25 Jan 2024 05:07:40 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4003a.ext.cloudfilter.net ([10.228.9.183]) by cmsmtp with ESMTPS id SagQrzLGuGAIJSrxjry6ok; Thu, 25 Jan 2024 05:07:39 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id SrxhrYv2u0nMNSrxirrkML; Thu, 25 Jan 2024 05:07:39 +0000 X-Authority-Analysis: v=2.4 cv=Qcx1A+Xv c=1 sm=1 tr=0 ts=65b1ec9b a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=kj9zAlcOel0A:10 a=dEuoMetlWLkA:10 a=iKhvJSA4AAAA:8 a=7Qk2ozbKAAAA:8 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=ADQM9SYy-IARRP2Jqu8A:9 a=CjuIK1q_8ugA:10 a=odh9cflL3HIXMm4fY7Wr:22 a=1lyxoWkJIXJV6VJUPhuM:22 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id B59CF306; Wed, 24 Jan 2024 21:07:36 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id A11871AC; Wed, 24 Jan 2024 21:07:36 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "Rodney W. Grimes" cc: George Michaelson , Warner Losh , Ed Maste , FreeBSD Current Subject: Re: Removing fdisk and bsdlabel (legacy partition tools) In-reply-to: <202401242347.40ONlWKZ099356@gndrsh.dnsmgr.net> References: <202401242347.40ONlWKZ099356@gndrsh.dnsmgr.net> Comments: In-reply-to "Rodney W. Grimes" message dated "Wed, 24 Jan 2024 15:47:32 -0800." List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 24 Jan 2024 21:07:36 -0800 Message-Id: <20240125050736.A11871AC@slippy.cwsent.com> X-CMAE-Envelope: MS4xfNlZ/A1I86hsxxRIIzsrJIefdbpI5tHzWVFwZnGSNmVzBO4YGoertr9NVMRfbSGiDMAK4EdyXwXY8y21Lo4PpAuk+AOLDLw+EqedIiKov/3Wwpix975f enmIMGxch/54d/TLgGaHByyqUKOK4Qsh7Bltf7xAI/4yctGXGhd22mGWUQ56YDgnjBvMtYOeZ4H9xPjZe/P/eYDLkM5W5hldGMOWdJv2uprXsfSL/fjoVqTo FxwlKrJ2wWWz8ZfkYnlG7iDhEloFfQBeKUp2H9h4i9zxcWrGwIop3J7BZSwWxH3r+v20pUa4ih+mKrSsSiNCRE3L4+HqZJQoxeqsPwzDeRY= X-Rspamd-Queue-Id: 4TL8304YnLz4WR8 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] In message <202401242347.40ONlWKZ099356@gndrsh.dnsmgr.net>, "Rodney W. Grimes" writes: > > I would agree personally, to moving to ports (eg ports/sysutils) with > > a DEPRECATED in the DESCR or something, or better yet a Make > > invokation event to say "superceded, here is how to proceed against > > advice") or something. > > They are totally useless as ports when your booted from install > media and working from a standalone shell. These are the exact > times you want things like fdisk and bsdlabel so you can figure > out wtf is going on, and bsdinstall is NOT gona help you. This is certainly a good point. > > I know there are a boat load of people that have built there > own installers for VM's and stuff, running UFS and I bet you > they are using MBR disks too. PLEASE do not kick these tiny > little and very usable and pretty univeral (as far as I know > ALL BSD's have fdisk and bsdlabel/disklabel) tools out of > the base system. > > The world is NOT 2TB nvme drives with GPT, EFI and ZFS, > yours might not be, but I am pretty certain I am not > alone in this other world. > > > -G > > > > On Thu, Jan 25, 2024 at 3:30?AM Warner Losh wrote: > > > > > > On Wed, Jan 24, 2024 at 8:45?AM Ed Maste wrote: > > >> > > >> MBR (PC BIOS) partition tables were historically maintained with > > >> fdisk(8), but gpart(8) has long been the preferred method for working > > >> with partition tables of all types. fdisk has been declared as > > >> obsolete in the man page since 2015. Similarly BSD disklabels were > > >> historically maintained with bsdlabel. It does not yet have a > > >> deprecation notice - I have proposed a man page addition in > > >> https://reviews.freebsd.org/D43563. > > >> > > >> I would like to disconnect these from the build, and subsequently > > >> remove them. This is prompted by a recent bsdlabel bug report which > > >> uncovered a longstanding buffer overflow in that tool. Effort is much > > >> better focused on contemporary, maintained tools rather than > > >> investigating issues in deprecated ones. Removing these tools would > > >> happen in FreeBSD 15 only (no change in 14 or 13). > > >> > > >> Code review to disconnect fdisk: https://reviews.freebsd.org/D43575 > > >> > > >> Note that this effort is limited to these maintenance tools only - > > >> there is no change to kernel or gpart support for MBR or BSD > > >> disklablel partitioning. That said, MBR partitioning and BSD > > >> disklabels are best considered legacy formats and should be avoided > > >> for new installations, if possible. > > >> > > >> If anyone is using fdisk and/or bsdlabel rather than gpart I would > > >> appreciate knowing what is preventing you from using the contemporary > > >> tools. > > > > > > > > > nanobsd's legacy.sh still is using disklabel in two spots. > > > > > > But one is to just do gpart create -s bsd and the other is to display it. > Easy > > > to fix, but even easier to delete legacy.sh entirely. It's not really nee > ded any > > > more and was a product of CHS addressing... Now that we use LBA, it's > > > better to use the new embedded ones. Even at $WORK where we kinda > > > use legacy, we replace the partitioning stuff with our own custom thing.. > . > > > > > > Those are the only users in the tree, but not for long :) > > > > > > fdisk was good, but somewhere around the CHS -> LBA transition things > > > got weird with it, and for really big disks there were reports of issues > that > > > I could never encounter when I set out to fix them... Most likely due to > a > > > mismatch in the CHS data and the LBA data being recorded in the MBR. > > > The in-kernel gpart copes so much better. > > > > > > I wouldn't object to making these ports, but both these programs use 'sek > ret' > > > bits from the kernel that might not remain exposed as we clean things up. > > > Though the IOCTLs they do (or used to do) may no longer be relevant. It's > > > been so long that I've forgotten.... > > > > > > Warner > -- > Rod Grimes rgrimes@freebsd.or > g > -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0