Date: Sun, 1 May 2022 17:27:37 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: cc1572ddeb8c - main - cam iosched: Remove write bias when read bias = 0 Message-ID: <202205011727.241HRblT061955@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=cc1572ddeb8cd82879ce0cca634bf6a8830c0f40 commit cc1572ddeb8cd82879ce0cca634bf6a8830c0f40 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2022-05-01 17:18:18 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2022-05-01 17:27:34 +0000 cam iosched: Remove write bias when read bias = 0 Change the meaning of read bias == 0 in the dynamic I/O scheduler. Prior to this change, a read bias of 0 would mean prefer writes. Now, when read bias is 0, we queue all requests to the same queue removing the bias. When it's non-zero, we still separate the queues we use so we can bias reads vs writes for workloads that are read centric. These changes restore the typical bias you get from disksort or ordered insertion at the end of the list. Sponsored by: Netflix --- sys/cam/cam_iosched.c | 84 ++++++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 69 insertions(+), 15 deletions(-) diff --git a/sys/cam/cam_iosched.c b/sys/cam/cam_iosched.c index 5b5e375cc8e2..7ddfabbe5125 100644 --- a/sys/cam/cam_iosched.c +++ b/sys/cam/cam_iosched.c @@ -1495,6 +1495,28 @@ cam_iosched_get_trim(struct cam_iosched_softc *isc) return cam_iosched_next_trim(isc); } + +static struct bio * +bio_next(struct bio *bp) +{ + bp = TAILQ_NEXT(bp, bio_queue); + /* + * After the first commands, the ordered bit terminates + * our search because BIO_ORDERED acts like a barrier. + */ + if (bp == NULL || bp->bio_flags & BIO_ORDERED) + return NULL; + return bp; +} + +#ifdef CAM_IOSCHED_DYNAMIC +static bool +cam_iosched_rate_limited(struct iop_stats *ios) +{ + return ios->state_flags & IOP_RATE_LIMITED; +} +#endif + /* * Determine what the next bit of work to do is for the periph. The * default implementation looks to see if we have trims to do, but no @@ -1527,27 +1549,54 @@ cam_iosched_next_bio(struct cam_iosched_softc *isc) return bp; } #endif - /* * next, see if there's other, normal I/O waiting. If so return that. */ - if ((bp = bioq_first(&isc->bio_queue)) == NULL) - return NULL; - #ifdef CAM_IOSCHED_DYNAMIC - /* - * For the dynamic scheduler, bio_queue is only for reads, so enforce - * the limits here. Enforce only for reads. - */ if (do_dynamic_iosched) { - if (bp->bio_cmd == BIO_READ && - cam_iosched_limiter_iop(&isc->read_stats, bp) != 0) { - isc->read_stats.state_flags |= IOP_RATE_LIMITED; - return NULL; + for (bp = bioq_first(&isc->bio_queue); bp != NULL; + bp = bio_next(bp)) { + /* + * For the dynamic scheduler with a read bias, bio_queue + * is only for reads. However, without one, all + * operations are queued. Enforce limits here for any + * operation we find here. + */ + if (bp->bio_cmd == BIO_READ) { + if (cam_iosched_rate_limited(&isc->read_stats) || + cam_iosched_limiter_iop(&isc->read_stats, bp) != 0) { + isc->read_stats.state_flags |= IOP_RATE_LIMITED; + continue; + } + isc->read_stats.state_flags &= ~IOP_RATE_LIMITED; + } + /* + * There can only be write requests on the queue when + * the read bias is 0, but we need to process them + * here. We do not assert for read bias == 0, however, + * since it is dynamic and we can have WRITE operations + * in the queue after we transition from 0 to non-zero. + */ + if (bp->bio_cmd == BIO_WRITE) { + if (cam_iosched_rate_limited(&isc->write_stats) || + cam_iosched_limiter_iop(&isc->write_stats, bp) != 0) { + isc->write_stats.state_flags |= IOP_RATE_LIMITED; + continue; + } + isc->write_stats.state_flags &= ~IOP_RATE_LIMITED; + } + /* + * here we know we have a bp that's != NULL, that's not rate limited + * and can be the next I/O. + */ + break; } - } - isc->read_stats.state_flags &= ~IOP_RATE_LIMITED; + } else #endif + bp = bioq_first(&isc->bio_queue); + + if (bp == NULL) + return (NULL); bioq_remove(&isc->bio_queue, bp); #ifdef CAM_IOSCHED_DYNAMIC if (do_dynamic_iosched) { @@ -1555,6 +1604,10 @@ cam_iosched_next_bio(struct cam_iosched_softc *isc) isc->read_stats.queued--; isc->read_stats.total++; isc->read_stats.pending++; + } else if (bp->bio_cmd == BIO_WRITE) { + isc->write_stats.queued--; + isc->write_stats.total++; + isc->write_stats.pending++; } else printf("Found bio_cmd = %#x\n", bp->bio_cmd); } @@ -1632,7 +1685,8 @@ cam_iosched_queue_work(struct cam_iosched_softc *isc, struct bio *bp) #endif } #ifdef CAM_IOSCHED_DYNAMIC - else if (do_dynamic_iosched && (bp->bio_cmd != BIO_READ)) { + else if (do_dynamic_iosched && isc->read_bias != 0 && + (bp->bio_cmd != BIO_READ)) { if (cam_iosched_sort_queue(isc)) bioq_disksort(&isc->write_queue, bp); else
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202205011727.241HRblT061955>