From nobody Wed Jul 15 21:27:23 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h0q583HcNz6m2xN for ; Wed, 15 Jul 2026 21:27:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h0q576SY0z3QjG for ; Wed, 15 Jul 2026 21:27:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784150843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cyqsAe+g5Qf0VtRavsOz9hcEwh+fioNjGeWRMXNd784=; b=Zaa0lpz0nLw3U+lppFm8aUBwpbzcV9Mci8OnfmEpMGIitYZFaM4BMG6ukNoIIJnT4wdbJb i+orW1TMF2P6kuEG4ai7xcBOve+lbYaUJrURRxwCpYKSc2IayTqI66Dqfo+aZ38zRFYfPZ hUmkfBERx+zkvsE9gwinV9UA36GOmFpR+eT3kCW8fSz4w8GdSz+ghtjcoKlOY/mgywhSUD Rbg8qrdBzUSBQIbOZeYNhh48iOq0ubjdMF9KoC3+0pJFCv1ov8nrxH690oxJFBTbqPC6ay GMyc8dVT41SnyqA2pQ6G84cBo0e5WjDfos0pSsBx7rQ1CRiv3MgRci68staNwg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784150843; a=rsa-sha256; cv=none; b=BqznrifimhMXoQ5UGjsuLsFVz69WA9655UoiWYdVKQNR/MyQpoOtgGZXd94yASxZkiIOfe C/aZZyh7brQD62djWg5Np5aRfkowy5+ZEZjA9Y+GavAe0ulu8PwyTUvB6oaGTm73j/+8qL 7tz7HGR8ddyIGthGoFPgvXNgFQtgJ+3x2w5UvTp0XfQJ33OYYyJG0G6z+dJKzwA8Kl1+Zd Mqa4DCWaYeCyGHwltrjtiFlUrj+XQwqzZTAGtmvb55f6CH4u5zSol0VYVdMjgOh4fg6VV+ y0Lu/7INvilHPlqeHYP7O9NYXXDa7caiYRFDOiDSUygcrnw6B5mSHgTPFrHHxw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784150843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cyqsAe+g5Qf0VtRavsOz9hcEwh+fioNjGeWRMXNd784=; b=qQnoR/+ZBhkDZZpOyleO0tY6KD4+1nQwOP17BlIt2MNpjL+HkNoqQRfxfwlrVUt0szgjiu cHZDZ9/mhyzweMzPilnQVPKgsGW3ZTw29rDn1A9DoCkqOf24pneDzJR9f2YXczP5Ok5JOH PnEjffWI/1a6QhuBYy5leRcAze9dJ+7FYDt4JW+xk/15x/Z19gCXLQV1XBt0nOYT8I08wk 57Zz55ncBSl0emhedr3f4e1Rb8EM2FhcBWL0L52l7IuzHWM+TY2mptqboUq8jwvz+THmaj 6xTIGMomFCD8oQQDmUYcuQKzNp/jn6/tFFLQidqP3APOK9znnb1bhfdQ/9v3GQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h0q574tVczntd for ; Wed, 15 Jul 2026 21:27:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19501 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 15 Jul 2026 21:27:23 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 664ad9ac4c90 - main - acpi_cpu(4): Call ACPI_GET_FEATURES() on a reset 'features' variable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 664ad9ac4c9047d29d5f37d43174e1b469e2ec80 Auto-Submitted: auto-generated Date: Wed, 15 Jul 2026 21:27:23 +0000 Message-Id: <6a57fb3b.19501.3a3766d7@gitrepo.freebsd.org> The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=664ad9ac4c9047d29d5f37d43174e1b469e2ec80 commit 664ad9ac4c9047d29d5f37d43174e1b469e2ec80 Author: Olivier Certner AuthorDate: 2026-07-07 13:34:21 +0000 Commit: Olivier Certner CommitDate: 2026-07-15 21:26:47 +0000 acpi_cpu(4): Call ACPI_GET_FEATURES() on a reset 'features' variable This is to prevent child drivers from using the features returned by previous drivers (in an arbitrary order). None of the existing ones do that, so this is purely defensive. MFC after: 2 weeks Sponsored by: The FreeBSD Foundation --- sys/dev/acpica/acpi_cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/acpica/acpi_cpu.c b/sys/dev/acpica/acpi_cpu.c index d2358f7077e5..48f6a27c1e89 100644 --- a/sys/dev/acpica/acpi_cpu.c +++ b/sys/dev/acpica/acpi_cpu.c @@ -313,7 +313,6 @@ acpi_cpu_attach(device_t dev) struct acpi_cpu_softc *sc; struct acpi_softc *acpi_sc; ACPI_STATUS status; - u_int features; int cpu_id, drv_count, i; driver_t **drivers; uint32_t cap_set[3]; @@ -417,6 +416,8 @@ acpi_cpu_attach(device_t dev) if (devclass_get_drivers(device_get_devclass(dev), &drivers, &drv_count) == 0) { for (i = 0; i < drv_count; i++) { + u_int features = 0; + if (ACPI_GET_FEATURES(drivers[i], &features) == 0) sc->cpu_features |= features; }