From nobody Mon Dec 22 16:19:28 2025 X-Original-To: dev-commits-doc-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dZjyw5RSPz6LQ26 for ; Mon, 22 Dec 2025 16:19:52 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dZjyw4yxpz3bZg for ; Mon, 22 Dec 2025 16:19:52 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-b7cee045187so741126466b.0 for ; Mon, 22 Dec 2025 08:19:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766420385; x=1767025185; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XCu1iBqmQJAYT3Ob0lPk4Gc1bifIVP52lSM4OyNPZ/4=; b=dP3lR3vFryFPK/u33IZbdHUf51zi0/Lmq0TmJ/qOISUKpa3OtEvI5a2yzek5V0aaem FF9rFdOVIdeoP+jsgxYT5nlP+VNOy2rjKs+FizrWMb2Hjb9mPum5FILTGi1Vc9NoLTOH jkp+AiTL9gGWcvONF5Dtw5VHAafh+R9q6OsBrWb5IfI5vJz4TAlauMvvCBD1oHh1W3Sh bTD1K8l76lPXkJM7LcEQTrhGwIQATKzP8M6JiS07B+3wZDy8B9mnhGWHmaWr4ZewE3CS z8ROHswoIOvtUvIztGh4AV5JEACHF2/zjTJM7SS6emAF//INXS+SZH+sqQQduKyBhKBR 8BiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766420385; x=1767025185; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XCu1iBqmQJAYT3Ob0lPk4Gc1bifIVP52lSM4OyNPZ/4=; b=v0sO4aW0P057V2LFwO3TDd39KyH6RMfbt97Y4xjMhyDNLDAoSUf/SsGITcNQ+Ou3G8 kzxIK70dbyaAJZtoLbeHRZSQwHeM2QKMARV+Eck4L5DXz+bwK+jXsi9149nuTlC8JoJy zsRfQSdFhU/o+tIvhEOoLjXjhk2JMJwgjjnY7HwaSn4R5o0JFZGr0pyvtkw0cLnEo2tY JiaXtuBbdok9NpY3sOdEDkshWUXD1dmHHhIOwNHISdZ2XbWggZKZhQblGHOOEmgL0idJ kufmBeWEjBjg2VPj/nADGg6dBiqRWSgfEXijOzIymQO2hnG7k8eRICO4gFBIij6KsKcm 75+A== X-Forwarded-Encrypted: i=1; AJvYcCUl6rj3SYsBdPR7xtHiPrB3PvsMzW23C+7/qbfvkyKa4KSZ6D8cR1c8zhmbkdyqBxLHprvTMbdKk9bRABJvujaM6wfX@freebsd.org X-Gm-Message-State: AOJu0YzK0V+QtMeF/0hwtUFk3GQ5SXnHVv6YOIlyvEb393fs0i8X77zG cT0NeJHfADaUljn+jAw7hbiL9qa/QKWNKSP8m/8i/CbvCiJaXes4gCum+U3jLUIR/4lNDphex/N AOPHQ+QMBQ5ACAuH91wVg7NpuKW8tPw== X-Gm-Gg: AY/fxX4cwHrqoHtsAl+fHg1SnffFpt2NZqi5gmEObmMUd9IhMhB2pMXzKu+XJxvoyuy goOgm+xx8mPbNhKZOBNEhHcUoFSat9+OZ2UwXRSCNaIb5/JgNEcqePZV311U7cnqsEEZfqqF5Hi wVpdOeOHThYglfxw2tYGz44eDrM7ZVjWrnJ7XUmvuebr2qG7PH3ButN4Qo9XMQ0bS8Bp4Zhzhq4 Wma+OJ73fd7gWAFvh94akglmvq7Rnv72ByrJxbOxvpk0W2P3YxrsDPMlgVegn2IjGyZpoQUPqFh cgK/GTN+cFFcaeiREHu30iZLTtI= X-Google-Smtp-Source: AGHT+IFEMmBe+0uIUP5ux33Id0OpTp7u9CIY+5+kML7cWNnHzRSN0ZE1Y5o2Gj4FcKxpaV5fNGSXiIvVIJlN+WKSbEc= X-Received: by 2002:a17:907:70d7:b0:b80:1403:764c with SMTP id a640c23a62f3a-b80205e6bd3mr1164452666b.24.1766420380590; Mon, 22 Dec 2025 08:19:40 -0800 (PST) List-Id: Commit messages for all branches of the doc repository List-Archive: https://lists.freebsd.org/archives/dev-commits-doc-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-doc-all@freebsd.org Sender: owner-dev-commits-doc-all@FreeBSD.org MIME-Version: 1.0 References: <69447e71.46420.2787bc4a@gitrepo.freebsd.org> <987ad115-9c14-4f5e-8e1d-ef69f84afd9e@FreeBSD.org> <273f7ba2-f3b0-4a1d-8267-dc48c8d659e2@FreeBSD.org> In-Reply-To: <273f7ba2-f3b0-4a1d-8267-dc48c8d659e2@FreeBSD.org> From: Rick Macklem Date: Mon, 22 Dec 2025 08:19:28 -0800 X-Gm-Features: AQt7F2qPdIfBciPdFFk9OptZIPXTi8BYT4b9LtEo84uNaWNSDpAqZJLh1nPhat0 Message-ID: Subject: Re: git: 481fce462d - main - Document various missing __FreeBSD_version values. To: John Baldwin Cc: src-committers , dev-commits-doc-all@freebsd.org, doc-committers@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4dZjyw4yxpz3bZg On Mon, Dec 22, 2025 at 8:02=E2=80=AFAM John Baldwin wrot= e: > > On 12/18/25 21:56, Rick Macklem wrote: > > On Thu, Dec 18, 2025 at 5:45=E2=80=AFPM John Baldwin = wrote: > >> > >> On 12/18/25 17:53, Rick Macklem wrote: > >>> I'm guilty. But someone said that it should only be bumped > >>> if no one else has bumped it recently. (Within a few days?) > >>> > >>> If it isn't getting bumped for every change, the document > >>> is basically useless, isn't it? > >> > >> The main reason it is documented in the porter's handbook is so that i= f ports > >> need to use conditional logic, this is a reference to which versions t= o use. > >> > >> Ports doesn't need perfect granularity (especially on main), just some= thing > >> that is "close", hence why bumping more often than, say, once a day is > >> probably overkill. > > Well, for my case it is inevitably "the internal KAPI between the NFS > > modules have changed and all of hem need to be rebuilt from sources". > > (Since this cannot affect any port, does it make sense to document it?) > > > > I do put entries in UPDATING. > > I do wonder for your case why you are bumping __FreeBSD_version? > > For other API changes that are internal to the kernel (and modules shippe= d > as part of the kernel), we don't generally bump __FreeBSD_version. Chang= es > to APIs include changes to source files (including headers) so the compil= er > should already recompile the right things based on dependencies for users > who are upgrading via source. Our current binary package systems for the > base system (both dist sets and pkgbase) always treat the entire kernel + > modules as a unit, so users should never get a mismatched set of NFS-rela= ted > kernel modules using binary updates either. > > I think the only case where bumping __FreeBSD_version for these commits c= an > catch something is that if a user builds the NFS kernel modules by hand > (e.g. cd /sys/modules/nfsfoo; make) or copies a module manually, the bump > will prevent loading a new module while an old kernel is running. It won= 't > though prevent loading an old module against a new kernel (the check we d= o > for kernel modules on main and stable branches is just a <=3D check, not = an > exact =3D=3D check). Given that, I'm not sure you need to be bumping > __FreeBSD_version for changes that change APIs between in-tree kernel > modules that are not used in ports. Perfect timing. I have a commit I'll be doing to-day that changes the inter= nal KAPI. I am happy to not bump the version and will only put an entry in UPDATING. (I don't recall who told me to bump the version for these changes, but it was quite a while ago.) Thanks, rick > > -- > John Baldwin >