Date: Tue, 09 Apr 2019 05:58:42 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 237132] devel/tcl-trf: crc-zlib broken Message-ID: <bug-237132-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D237132 Bug ID: 237132 Summary: devel/tcl-trf: crc-zlib broken Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: regulaar@gmail.com CC: mi@ALDAN.algebra.com CC: mi@ALDAN.algebra.com Flags: maintainer-feedback?(mi@ALDAN.algebra.com) crc-zlib is broken in devel/tcl-trf after port rev. 482639. Proof: % package require Trf 2.1.4 % set chk [crc-zlib {Hello, World!}] % binary scan $chk i chksum 1 % format 0x%x $chksum 0x0 But we should get something different: https://wiki.tcl-lang.org/page/Trf Apparently this is introduced in the following lines in patch-zlib: 190 - CRC =3D zf.zcrc32 (CRC, buffer, bufLen); 191 + CRC =3D crc32(0L, Z_NULL, 0); No data are ever CRC'd here. For Adler checksum things are better: 48 - ADLER =3D zf.zadler32 (ADLER, buffer, bufLen); 49 + ADLER =3D adler32 (ADLER, buffer, bufLen); I hope no other filters are affected. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-237132-7788>