From owner-freebsd-current@FreeBSD.ORG Mon Jun 1 15:50:01 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 02C3010657C2 for ; Mon, 1 Jun 2009 15:50:01 +0000 (UTC) (envelope-from bms@incunabulum.com) Received: from out2.smtp.messagingengine.com (out2.smtp.messagingengine.com [66.111.4.26]) by mx1.freebsd.org (Postfix) with ESMTP id C71618FC27 for ; Mon, 1 Jun 2009 15:49:59 +0000 (UTC) (envelope-from bms@incunabulum.com) Received: from compute2.internal (compute2.internal [10.202.2.42]) by out1.messagingengine.com (Postfix) with ESMTP id 8886B34C17A; Mon, 1 Jun 2009 11:30:44 -0400 (EDT) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute2.internal (MEProxy); Mon, 01 Jun 2009 11:30:44 -0400 X-Sasl-enc: TebyRTTRtuXwYNKVt6Wn6rlpSCRqRbOHhKvEMOCtrs19 1243870243 Received: from empiric.lon.incunabulum.net (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTPSA id 03DD826891; Mon, 1 Jun 2009 11:30:42 -0400 (EDT) Message-ID: <4A23F421.8070809@incunabulum.com> Date: Mon, 01 Jun 2009 16:30:41 +0100 From: Bruce Simpson User-Agent: Thunderbird 2.0.0.21 (X11/20090412) MIME-Version: 1.0 To: deeptech71@gmail.com References: <4A1DD57A.7010704@gmail.com> <4A1E9831.4010606@incunabulum.net> <4A1EC8FB.6090206@gmail.com> <4A1FBFF5.6090103@incunabulum.net> <4A20791D.5070209@gmail.com> <4A22E2F1.6070404@incunabulum.net> <4A2325F1.8010300@gmail.com> In-Reply-To: <4A2325F1.8010300@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 01 Jun 2009 16:12:39 +0000 Cc: freebsd-current@freebsd.org Subject: Re: panic: igmp_v3_dispatch_general_query: called when version 2 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2009 15:50:01 -0000 deeptech71@gmail.com wrote: >> >> Thanks. Can you please test this patch and let me know if it works >> for you? > > OK, applied, but what now? If you are sure that you have fixed the > bug, but just want me to run a "crash test" before commiting, then all > I can say is there's nothing wrong yet, I'll keep running the patch > until something comes up, like a panic (and report it). Otherwise I > can't test wether the patch does avoid the non-reproducable panic. I believe (without reproducing it) that the problem was igmp_v3_cancel_link_timers() not cancelling the v3 link timer in all situations. The panic you saw was due to a v3 timer firing even though the timer should have been cancelled by reception of the v2 query from your university's LAN router. The RFC could be worded better about how the 'Older Querier' timer is heeded -- on re-reading it makes sense not to flap between IGMP versions -- the oldest version in use on the link persists for up to 260s with the default protocol timers, only switching version after the timer expires is best as it provides some built-in hysteresis. It sounds like the fix is OK. Obviously, let me know if you see problems again, I've checked the patch into HEAD now. thanks, BMS