From owner-freebsd-current@FreeBSD.ORG Mon Dec 17 05:06:40 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3EC67A80; Mon, 17 Dec 2012 05:06:40 +0000 (UTC) (envelope-from jim.harris@gmail.com) Received: from mail-we0-f182.google.com (mail-we0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 72E358FC12; Mon, 17 Dec 2012 05:06:39 +0000 (UTC) Received: by mail-we0-f182.google.com with SMTP id u54so2534319wey.13 for ; Sun, 16 Dec 2012 21:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=1a6YwoK/NvrK7xCnrVBQB4R87/qBE4P+aiotwNUqodA=; b=gJFrBBffBvT2BbGh7V62LowUBjVmUXEji+qgjK31QxAqNXp5guxKTgc2B5r7CeG1YY 48+ffHQ+dR5yBG0r/kaGYtXFeTgL8i04n0vh9yYpCEtbRJa9Dk6c3FBTDs9SyAFNaQ/l Tc0FsaJKKvEckeb7mwYOvz/EilkF8waBYZ59zKn4SPtZKHVofd3MFYi2W2DyoOD8r9ST GbUO9Zv0ltsd5jRlE5q6/kgrp+K79mr7lNYzfPLhMYEkCBaEr2TyzshT0YC14TnPcoYK 31yYiKZpW6o6varQsMXU0dYcXKnm06LOpcIwwmrD2pzIllAq0wR2q7vhDzRKpMJBQy7N sVwQ== MIME-Version: 1.0 Received: by 10.180.75.135 with SMTP id c7mr13408691wiw.10.1355720798339; Sun, 16 Dec 2012 21:06:38 -0800 (PST) Sender: jim.harris@gmail.com Received: by 10.217.57.4 with HTTP; Sun, 16 Dec 2012 21:06:38 -0800 (PST) In-Reply-To: References: Date: Sun, 16 Dec 2012 22:06:38 -0700 X-Google-Sender-Auth: QdIxRHUlONSyw1E7xRDoEVtCnPI Message-ID: Subject: Re: VirtIO in GENERIC From: Jim Harris To: Andrew Thompson Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Bryan Venteicher , freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Dec 2012 05:06:40 -0000 On Sun, Dec 16, 2012 at 6:53 PM, Andrew Thompson wrote: > On 17 December 2012 13:17, Bryan Venteicher wrote: > > > There's been lots of requests to have VirtIO in GENERIC for i386 and > > amd64. Anybody have any issues or concerns with this or the patch at > > [1]. This also removes the kludge that was introduced in r239009. > > > > I've compiled LINT for i386 and amd64 so hopefully there won't be any > > surprise breakages. > > > > [1] http://people.freebsd.org/~bryanv/patches/virtio.generic.patch > > > It would be great to have the drivers enabled. You do not need the > sys/conf/files changes, the common and arch files are combined. > > Removing the virtio files from sys/conf/files ensures these drivers can only be specified in x86 kernel configuration files. r239009 added these lines to sys/conf/files, but Bryan's patch does it more correctly. The only question I have is the GENERIC changes where "device virtio" is added - it says it is required, but should this instead say it's required for any of the other drivers in this section? -Jim