From owner-freebsd-current@FreeBSD.ORG Thu Apr 12 18:48:07 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DF342106566B; Thu, 12 Apr 2012 18:48:07 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id BCA458FC1B; Thu, 12 Apr 2012 18:48:07 +0000 (UTC) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.5/8.14.5) with ESMTP id q3CIfEfN053556; Thu, 12 Apr 2012 11:41:14 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.5/8.14.5/Submit) id q3CIfEPK053555; Thu, 12 Apr 2012 11:41:14 -0700 (PDT) (envelope-from obrien) Date: Thu, 12 Apr 2012 11:41:14 -0700 From: "David O'Brien" To: jasone@freebsd.org Message-ID: <20120412184114.GB71001@dragon.NUXI.org> Mail-Followup-To: obrien@freebsd.org, jasone@freebsd.org, freebsd-current@freebsd.org References: <431CB493-836B-4DF4-AC42-A7C6ABF7DE3E@canonware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <431CB493-836B-4DF4-AC42-A7C6ABF7DE3E@canonware.com> X-Operating-System: FreeBSD 10.0-CURRENT X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? User-Agent: Mutt/1.5.20 (2009-06-14) Cc: freebsd-current@freebsd.org Subject: Re: contrib/jemalloc X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2012 18:48:08 -0000 On Wed, Apr 04, 2012 at 09:56:45PM -0700, Jason Evans wrote: > I have the current version of jemalloc integrated into libc as contrib/jemalloc: > http://people.freebsd.org/~jasone/patches/jemalloc_20120404b.patch Looking at the latest patch http://people.freebsd.org/~jasone/patches/jemalloc_20120405a.patch I cannot tell for sure if you did an 'svn move' of the files from lib/libc/stdlib/ to contrib/jemalloc/. It looks to me like they have not. If not, can you regen the diff after using 'svn move' so we maintain log history? > * Is it acceptable to check this in directly to trunk without using a > vendor branch? For the import workflow I have planned, a vendor branch > would just be extra work with no benefit that I can see. I do not think it is acceptable. Our workflow is to do vendor imports. They are invaluable in tracking down history and changes years after the fact. They are also very valuable to commercial third-parties that consume FreeBSD into their products (I speak for Juniper Networks in this). Why do you feel they are [measurably] extra work with no benefit? -- -- David (obrien@FreeBSD.org)