From owner-svn-src-projects@freebsd.org Wed Mar 27 02:59:27 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D332A1567989 for ; Wed, 27 Mar 2019 02:59:27 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3D8F391B01; Wed, 27 Mar 2019 02:59:27 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-f196.google.com with SMTP id l7so13000936ljg.6; Tue, 26 Mar 2019 19:59:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=FUzZwbjRIK92xVqT3T/DrXu+NNRf8uYr7x9H8g3E1yo=; b=IUGcYKcuqa/Ip/0fFohxYiMsnbNzk4iML0Ekzj+xULIXEMSP1vU19yqjLvAzxn/KQS H3qs5mpW1nSMJtMQy8Op7JvLT4QZOj30oAp3zk2RaQdGGV9mr6a5WjRWn0vukOG5zfY5 gniQDGLLM4soJoTe11nxvBKprB4rvwVBk96+JIOtoTiI22BPEeTyaNJRFSXQ4MIHhe9/ 8x29+D/d5tRNZKE8el5eQkMhUdS+XRR7VP5HMc+6Dx+aydCdjC8db2U9ItTOjNnTp8gq UrpcvevLxz5/IviCntDZ9CMpQ+ovpJMwig2PTyC7/JL/1M9mUvl7vAqFafg4zMdss3F7 9iLg== X-Gm-Message-State: APjAAAW1SC0ijjHdevnhCHxxQrxDLqQyDNx7+V6shtDbKBL8NKqLxyWa mVx+WzbUFSJsgY5BA6qi/a2RSNRLKIN04RIdOOs= X-Google-Smtp-Source: APXvYqzNMMjHkACgKYc1aCu3Y85mhRTp5DOnPgmEFdJLzAZ0QBP1zVgq4FseCGPUjFuUo1fUHCMw5Du8ZAgxLHn8ijU= X-Received: by 2002:a05:651c:114:: with SMTP id a20mr18110862ljb.53.1553655560015; Tue, 26 Mar 2019 19:59:20 -0700 (PDT) MIME-Version: 1.0 References: <201903270024.x2R0Ov1e073868@repo.freebsd.org> <43ACF554-1D64-4CDE-AB22-8A13E3585CC9@gmail.com> In-Reply-To: <43ACF554-1D64-4CDE-AB22-8A13E3585CC9@gmail.com> From: Alan Somers Date: Tue, 26 Mar 2019 20:59:08 -0600 Message-ID: Subject: Re: svn commit: r345563 - projects/fuse2/tests/sys/fs/fusefs To: Enji Cooper Cc: src-committers , svn-src-projects@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3D8F391B01 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.93 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.995,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.94)[-0.936,0] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Mar 2019 02:59:28 -0000 On Tue, Mar 26, 2019 at 8:39 PM Enji Cooper wrote: > > > On Mar 26, 2019, at 5:24 PM, Alan Somers wrote: > > Author: asomers > Date: Wed Mar 27 00:24:57 2019 > New Revision: 345563 > URL: https://svnweb.freebsd.org/changeset/base/345563 > > Log: > fusefs: fix a race condition in the allow_other test > > The test could occasionally hang if the parent's SIGUSR2 signal arrived > before the child had pause()d. Using POSIX semaphores precludes that > possibility. > > Sponsored by: The FreeBSD Foundation > > > =E2=80=A6 > > + sem =3D (sem_t*)mmap(NULL, sizeof(*sem), mprot, mflags, -1, 0); > + ASSERT_NE(NULL, sem) << strerror(errno); > > > mmap will return =E2=80=9CMAP_FAILED=E2=80=9D, not NULL, on error. > > Thanks, > -Enji Whoops! Good catch.