From owner-svn-src-all@FreeBSD.ORG Wed Dec 8 09:24:10 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1738910656D7; Wed, 8 Dec 2010 09:24:10 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id AF30C8FC42; Wed, 8 Dec 2010 09:24:09 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 54F5745CDC; Wed, 8 Dec 2010 10:24:08 +0100 (CET) Received: from localhost (pdawidek.whl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 0F98B45CD8; Wed, 8 Dec 2010 10:24:03 +0100 (CET) Date: Wed, 8 Dec 2010 10:24:02 +0100 From: Pawel Jakub Dawidek To: Martin Matuska Message-ID: <20101208092402.GC1692@garage.freebsd.pl> References: <201012080857.oB88vbH6096250@svn.freebsd.org> <20101208090433.GB1692@garage.freebsd.pl> <4CFF4C65.4030607@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RIYY1s2vRbPFwWeW" Content-Disposition: inline In-Reply-To: <4CFF4C65.4030607@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=4.5 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216291 - head/cddl/contrib/opensolaris/lib/libzfs/common X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2010 09:24:10 -0000 --RIYY1s2vRbPFwWeW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 08, 2010 at 10:14:13AM +0100, Martin Matuska wrote: > Here are some arguments: >=20 > a) it was removed in OpenSolaris rev. 12865:08987220809a > b) a root pool does not not have to be a boot pool >=20 > So if we need a warning here, it should print only some general > suggestion because > user may attach any vdev (e.g. a file or a memory disk) to make a mirror > from a root pool. > And as this was removed upstream the warning should be put into perforce > as well. Hmm, I think I saw this warning on more recent ZFS. All in all we currently print this when we upgrade root pool we print the following: If you boot from pool 'foo', don't forget to update boot code. Assuming you use GPT partitioning and da0 is your boot disk the following command will do it: gpart bootcode -b /boot/pmbr -p /boot/gptzfsboot -i 1 da0 (Note, that bootfs property doesn't have to be set to boot from a pool.) We should print similar information when: - We set bootfs property. - Add new vdev(s) to root pool. - Attach new vdev(s) to root pool. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --RIYY1s2vRbPFwWeW Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkz/TrIACgkQForvXbEpPzQVswCfSm4zSNXnJtB0VncSQk9H9DNc HkwAn35XzoBm4ensov/grw4zAynD4Prx =QbW5 -----END PGP SIGNATURE----- --RIYY1s2vRbPFwWeW--