From owner-svn-src-all@FreeBSD.ORG Mon Oct 22 13:04:22 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E3898CD4 for ; Mon, 22 Oct 2012 13:04:21 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by mx1.freebsd.org (Postfix) with ESMTP id A28098FC1C for ; Mon, 22 Oct 2012 13:04:21 +0000 (UTC) Received: by mail-pa0-f54.google.com with SMTP id bi1so1982484pad.13 for ; Mon, 22 Oct 2012 06:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=M24QaonCY9RH2vgO44JYDjnLcAne7k98xjlaEQSmjLU=; b=s8ymfDq4qgk++RRGdriqXS7PvW45uRpdqyUOnrjI9ZgksXCXovgSNpfalMHPnosJ+7 8HbWVXH+LkV85OvqjU91NjLD836O1kkVgDVxlp8vjp0Tk2Rr/2fwuANBrxqICCZ6cGgF ooWYNIxGiEr2DZveQ9hAYKCPwlkpRNgaC81RE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=M24QaonCY9RH2vgO44JYDjnLcAne7k98xjlaEQSmjLU=; b=HAkaZlro0iTKfUg/cWJZ7FZdrJXhwer4YDJ8rn6SUZ1QttyzJjZsg7gaJMqvNiQpfV /cqK9Q9tUqlqlUjjlxE7NWrjyMTKJRQ0dGkmUHrk9LryebGITlteavwi3RXqYphpJ/up TvY/N7Kvp9gQeygsXTl7pV751cgxzxvROvTe9lJlJgmDiSiM+6kwXY1PGuZPKe+uEni3 McvFTt83c/ZWsKrshNeWFNF/HJScQAlb2PBH0nO90Fvbj2aGfV3EX5rIlJw/U1BTIwjA DZA6WeJGQ1cBHnEy+UEcLH6ik5SlFPkzsPGdYSc1RldEZJNc6WzE/VbcN/UF5604AGXM tkNg== Received: by 10.68.200.231 with SMTP id jv7mr29463607pbc.140.1350911060988; Mon, 22 Oct 2012 06:04:20 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.66.161.163 with HTTP; Mon, 22 Oct 2012 06:03:50 -0700 (PDT) In-Reply-To: <201210220842.31106.jhb@freebsd.org> References: <201210220341.q9M3fEdu023999@svn.freebsd.org> <201210220842.31106.jhb@freebsd.org> From: Eitan Adler Date: Mon, 22 Oct 2012 09:03:50 -0400 X-Google-Sender-Auth: aQN3Gq7dKP-ROV5_ZwhM0Yfzj5Y Message-ID: Subject: Re: svn commit: r241856 - in head/sys: arm/xscale/pxa dev/acpica dev/agp dev/amdsbwd dev/amdtemp dev/asmc dev/coretemp dev/e1000 dev/glxiic dev/ixgbe dev/kbdmux dev/sound/pci i386/acpica i386/bios x86/... To: John Baldwin Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQkn78UMlbs6HEKVG4JLVRTSLmRejVVfvwm77pYinRz+dC4ar6jEzKiE6wFtiTHiut+mOMA6 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2012 13:04:22 -0000 On 22 October 2012 08:42, John Baldwin wrote: > On Sunday, October 21, 2012 11:41:14 pm Eitan Adler wrote: >> Author: eadler >> Date: Mon Oct 22 03:41:14 2012 >> New Revision: 241856 >> URL: http://svn.freebsd.org/changeset/base/241856 >> >> Log: >> Now that device disabling is generic, remove extraneous code from the >> device drivers that used to provide this feature. > > This isn't functionally identical. In some cases a hint to disable > unit 0 would in fact disable all units. For example, disabling est0 and > acpi_perf0 disabled all instances of estX and acpi_perfX, not just the > first one. You should test this on a multi-CPU machine before and after > to see the different effects. > > The one in the x86 code that handles early mapping of ACPI tables before > new-bus is around is also very important (acpi_find_table()). You just > broke booting on SMP systems where ACPI is disabled but that contain an > MADT for example (pretty much all modern x86 SMP systems). > > elcr is also not a new-bus device, so removing that hint broke that > psuedo-driver as well. > > It is only safe to remove these calls in new-bus attach (not probe!) > routines that are using 'device_get_unit()' and not hardcoding the > unit to 0 (unless you know for certain that there can only ever be one > instance of this device such as acpi0 or asmc0). Thanks for the information. I will revert and come up with a better patch. -- Eitan Adler Source & Ports committer X11, Bugmeister, Ports Security teams