From owner-freebsd-fs@FreeBSD.ORG Sat Dec 13 19:23:21 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D899C1065672 for ; Sat, 13 Dec 2008 19:23:21 +0000 (UTC) (envelope-from rick@kiwi-computer.com) Received: from kiwi-computer.com (keira.kiwi-computer.com [63.224.10.3]) by mx1.freebsd.org (Postfix) with SMTP id 67CBB8FC1C for ; Sat, 13 Dec 2008 19:23:21 +0000 (UTC) (envelope-from rick@kiwi-computer.com) Received: (qmail 98002 invoked by uid 2001); 13 Dec 2008 19:23:20 -0000 Date: Sat, 13 Dec 2008 13:23:20 -0600 From: "Rick C. Petty" To: Jaakko Heinonen Message-ID: <20081213192320.GA97766@keira.kiwi-computer.com> References: <20081213173902.GA96883@keira.kiwi-computer.com> <20081213183058.GA20992@a91-153-125-115.elisa-laajakaista.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081213183058.GA20992@a91-153-125-115.elisa-laajakaista.fi> User-Agent: Mutt/1.4.2.3i Cc: freebsd-fs@freebsd.org Subject: Re: UFS label limitations X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: rick-freebsd2008@kiwi-computer.com List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Dec 2008 19:23:21 -0000 On Sat, Dec 13, 2008 at 08:30:59PM +0200, Jaakko Heinonen wrote: > > geom_label has problems with other characters too. The problem is that > it doesn't encode characters for XML output properly. See these PRs: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/104389 > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/120044 > > This already causes problems with file systems which allow non-ASCII > label names. IMO the problem should be addressed before extending > allowed characters in UFS labels. Well at the very least can we allow all characters between 0x20 and 0x7e except for: "&/<>\ Why hasn't the patch from kern/104389 made it in to geom? It's been almost 20 months since any activity on it. The last patch seems pretty good, except for NUL and SOH (0x00 and 0x01), but can't you just use "&#xx;" encoding for those also? XML has its own limitations. I don't think it's worth limiting everybody else just because of this XML bug. -- Rick C. Petty