From owner-freebsd-bugs@FreeBSD.ORG  Sun Mar  6 11:28:29 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 593AE106566B;
	Sun,  6 Mar 2011 11:28:29 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail01.syd.optusnet.com.au (mail01.syd.optusnet.com.au
	[211.29.132.182])
	by mx1.freebsd.org (Postfix) with ESMTP id BE2F68FC0A;
	Sun,  6 Mar 2011 11:28:28 +0000 (UTC)
Received: from c122-107-125-80.carlnfd1.nsw.optusnet.com.au
	(c122-107-125-80.carlnfd1.nsw.optusnet.com.au [122.107.125.80])
	by mail01.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	p26BSJS4005477
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sun, 6 Mar 2011 22:28:25 +1100
Date: Sun, 6 Mar 2011 22:28:19 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Martin Matuska <mm@FreeBSD.org>
In-Reply-To: <20110306104825.8B860F1DEF@mail2.vx.sk>
Message-ID: <20110306222256.Y1086@besplex.bde.org>
References: <20110306104825.8B860F1DEF@mail2.vx.sk>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-bugs@FreeBSD.org, FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: gnu/155309: [PATCH] gcc: backport bswap32() and bswap64()
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Mar 2011 11:28:29 -0000

On Sun, 6 Mar 2011, Martin Matuska wrote:

>> Description:
> In many ports, we have to deal with patching the missing bswap32()
> and bswap64() functions.

Er, we have these in endian.h.

> The gcc-4.3 branch SVN revision is 118361, is GPLv2-licensed,
> applies cleanly and is fully compatible with our code.

However, gcc doesn't know how to turn a C expression for bswap*() into
the bswap instruction.  clang does.  Does this patch fix that?  Using
the C expression in all cases allows cleaning endian.h files, except
possibly on other arches that still need asm.

Bruce