From owner-cvs-all Tue Feb 12 15: 6:17 2002 Delivered-To: cvs-all@freebsd.org Received: from patrocles.silby.com (d73.as20.nwbl0.wi.voyager.net [169.207.138.73]) by hub.freebsd.org (Postfix) with ESMTP id 2086A37B402; Tue, 12 Feb 2002 15:06:09 -0800 (PST) Received: from localhost (silby@localhost) by patrocles.silby.com (8.11.6/8.11.6) with ESMTP id g1CH9sa03528; Tue, 12 Feb 2002 17:09:56 GMT (envelope-from silby@silby.com) X-Authentication-Warning: patrocles.silby.com: silby owned process doing -bs Date: Tue, 12 Feb 2002 17:09:54 +0000 (GMT) From: Mike Silbersack To: David Malone Cc: cvs-committers@FreeBSD.org, Subject: Re: cvs commit: src/sys/conf options.i386 options.pc98 src/sys/i386/conf NOTES src/sys/i386/i386 initcpu.c In-Reply-To: <200202122210.aa14625@salmon.maths.tcd.ie> Message-ID: <20020212170729.P2904-100000@patrocles.silby.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 12 Feb 2002, David Malone wrote: > > Could you make this a loader tunable? Recompiling a kernel just for a few > > lines of code is a huge pain. > > Since it is a hack for borked BIOS code, I think having it as an > option is probably fine (just like all the other magic CPU options). > Adding the option to GENERIC and reconfiguring only results in the > recompilation of 3/4 files. > > If people feel that it would really be more useful as a tunable, > then I can figure out how that is done. > > David. As easy as recompiling a kernel is, just setting a variable in loader.conf and rebooting is a lot easier. The code's simple: int athlonenablesse; TUNABLE_INT_FETCH("workaround.broken.athlon.bios.that.didnt.set.sse", &athlonenablesse); And then trigger based off that variable. Its value should not change if the tunable isn't found. You may also wish to consider a shorter tunable name. :) Mike "Silby" Silbersack To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message