From owner-svn-src-head@freebsd.org Tue Sep 22 09:43:05 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7D6A1A06774; Tue, 22 Sep 2015 09:43:05 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3A6CD161B; Tue, 22 Sep 2015 09:43:05 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1ZeK6H-000Bai-Q5; Tue, 22 Sep 2015 12:43:01 +0300 Date: Tue, 22 Sep 2015 12:43:01 +0300 From: Slawa Olhovchenkov To: Dimitry Andric Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r288099 - head/contrib/binutils/opcodes Message-ID: <20150922094301.GW3158@zxy.spb.ru> References: <201509220935.t8M9ZZfD051027@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201509220935.t8M9ZZfD051027@repo.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2015 09:43:05 -0000 On Tue, Sep 22, 2015 at 09:35:35AM +0000, Dimitry Andric wrote: > Author: dim > Date: Tue Sep 22 09:35:35 2015 > New Revision: 288099 > URL: https://svnweb.freebsd.org/changeset/base/288099 > > Log: > In binutils' arm-dis.c, avoid left-shifting a negative number. > > Submitted by: dan.mcgregor_usask.ca (Dan McGregor) > MFC after: 3 days > Differential Revision: https://reviews.freebsd.org/D3376 > > Modified: > head/contrib/binutils/opcodes/arm-dis.c > > Modified: head/contrib/binutils/opcodes/arm-dis.c > ============================================================================== > --- head/contrib/binutils/opcodes/arm-dis.c Tue Sep 22 07:40:55 2015 (r288098) > +++ head/contrib/binutils/opcodes/arm-dis.c Tue Sep 22 09:35:35 2015 (r288099) > @@ -1767,7 +1767,7 @@ print_insn_coprocessor (bfd_vma pc, stru > > /* Is ``imm'' a negative number? */ > if (imm & 0x40) > - imm |= (-1 << 7); > + imm |= -(1 << 7); May be (~0 << 7) is more simple to understund?