From owner-cvs-all  Mon Mar  5  6:25:10 2001
Delivered-To: cvs-all@freebsd.org
Received: from cartier.cirx.org (cartier.cirx.org [211.72.15.243])
	by hub.freebsd.org (Postfix) with ESMTP
	id 075B137B719; Mon,  5 Mar 2001 06:24:51 -0800 (PST)
	(envelope-from clive@CirX.ORG)
Received: from cartier.cirx.org (nullmail@localhost [127.0.0.1])
	by cartier.cirx.org (8.11.3/8.11.3) with SMTP id f25EOMu51780;
	Mon, 5 Mar 2001 22:24:23 +0800 (CST)
	(envelope-from clive@CirX.ORG)
Received: (nullmailer pid 51776 invoked by uid 1000);
	Mon, 05 Mar 2001 14:24:22 -0000
Date: Mon, 5 Mar 2001 22:24:22 +0800
From: Clive Lin <clive@CirX.ORG>
To: Jim Bloom <bloom@acm.org>
Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: ports/security/p5-Net-SSLeay Makefile
Message-ID: <20010305222422.A51613@cartier.cirx.org>
References: <200103050839.f258dZ256801@freefall.freebsd.org> <3AA39CCA.F6DAAD75@acm.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <3AA39CCA.F6DAAD75@acm.org>; from bloom@acm.org on Mon, Mar 05, 2001 at 09:03:54AM -0500
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Hi,

    This won't break anything because if perl can't find where openssl
is, perl will simply ask where to find openssl just like the old
way. Before I did this commit, this port would act funny. It wanted to
search "CC=cc" because PERL_CONFIGURE would pass "CC=cc" to it. Now if
this port can't find openssl in "/usr"."bin/openssl", it would say "I
can't find openssl in /usr, please tell me where it is" instead of "I
can't find openssl in CC=cc, please .................."


    Actually, I think currently p5-Net-SSLeay is somewhat lame. It
should depends on ports/security/openssl if ${OSVERSION} is prior to
40014.

    Anyway, hope this explains... :-)

On Mon, Mar 05, 2001 at 09:03:54AM -0500, Jim Bloom wrote:
> Actually, did you just break RELENG_3 and early versions of RELENG_4 with this
> commit?  It would have been easy to simply check the system version and make the
> change conditional upon.  A block like
> 
> .if ${OSVERSION} >= 40014
> CONFIGURE_ARGS+=       "/usr"
> .endif
> 
> does the job. That version is where openssl was added to the base system.
> 
> Jim Bloom
> bloom@acm.org
> 
> Clive Lin wrote:
> > 
> > clive       2001/03/05 00:39:33 PST
> > 
> >   Modified files:
> >     security/p5-Net-SSLeay Makefile
> >   Log:
> >   Dumb-safe. Tell p5-Net-SSLeay that our openssl lives under "/usr"
> > 
> >   Since we don't support RELENG_3 now, it's fairly enough to assume
> >   that `which openssl` is /usr/bin/openssl.

-- 
pub  1024D/F8D2B472 2000-08-05 Clive Lin <clive@CirX.ORG>
     Key fingerprint = 7F9D 57A8 55C7 AA18 49B5  3820 570B 27F6 F8D2 B472

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message