From owner-freebsd-current@freebsd.org Tue Jan 26 12:29:35 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 033ED4ECA33 for ; Tue, 26 Jan 2021 12:29:35 +0000 (UTC) (envelope-from fluffy@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DQ5dp6kV6z3lDn; Tue, 26 Jan 2021 12:29:34 +0000 (UTC) (envelope-from fluffy@FreeBSD.org) Received: from [192.168.1.6] (host.212-19-20-216.broadband.redcom.ru [212.19.20.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: fluffy) by smtp.freebsd.org (Postfix) with ESMTPSA id 7040A9E89; Tue, 26 Jan 2021 12:29:33 +0000 (UTC) (envelope-from fluffy@FreeBSD.org) Date: Tue, 26 Jan 2021 22:29:29 +1000 From: Dima Panov To: Stefan Esser , monochrome , vbox@freebsd.org, freebsd-current@freebsd.org Message-ID: In-Reply-To: References: <58f5f4d8-c722-35eb-a66e-225d799e4a89@twcny.rr.com> Subject: Re: problem building virtualbox-ose-kmod MIME-Version: 1.0 Content-Type: multipart/signed; boundary="60100b2a_46e87ccd_a665"; protocol="application/pgp-signature" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2021 12:29:35 -0000 --60100b2a_46e87ccd_a665 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Moin=21 Stefan, please add check for =5F=5F=46reeBSD=5Fversion and fill PR or com= mit it directly with ports-secteam approval. -- Dima. (desktop, kde, x11, office, ports-secteam)=40=46reeBSD team (fluffy=40=46reeBSD.org, https://t.me/dima=5Fpanov) > On Tuesday, Jan 26, 2021 at 8:37 PM, Stefan Esser wrote: > Am 26.01.21 um 07:34 schrieb monochrome: > > having this issue building virtualbox-ose-kmod, its been like this fo= r a > > while but I deinstalled and forgot, for quite a while now, maybe over= a > > month. now that I've moved from 13-current to stable/13 I thought I > > would try to put it back, but it still wont build. I haven't seen any= one > > else with this problem, did I miss a memo=3F > > I have sent a patch to vbox=40on 2020-01-16, but only received an > automatic reply that it had to be accepted by the moderator of the > list (and never got any further reply or reaction on it). > > The signature of vm=5Fmap=5Fprotect() has changed, but the port has not= > been updated. > > Here is the patch in case the attachment gets stripped (but probably > with messed-up white-space): > > Index: files/patch-src=5FVBox=5FRuntime=5Fr0drv=5Ffreebsd=5Fmemobj-r0dr= v-freebsd.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- files/patch-src=5FVBox=5FRuntime=5Fr0drv=5Ffreebsd=5Fmemobj-r0drv-f= reebsd.c > (revision 561738) > +++ files/patch-src=5FVBox=5FRuntime=5Fr0drv=5Ffreebsd=5Fmemobj-r0drv-f= reebsd.c > (working copy) > =40=40 -421,7 +421,8 =40=40 > =40=40 -826,6 +885,7 =40=40 DECLHIDDEN(int) rtR0MemObjNativeProtect(PRT= R0MEMOBJINT > Protection=46lags =7C=3D VM=5FPROT=5FEXECUTE; > > - int krc =3D vm=5Fmap=5Fprotect(pVmMap, AddrStart, AddrEnd, > Protection=46lags, =46ALSE); > +- int krc =3D vm=5Fmap=5Fprotect(pVmMap, AddrStart, AddrEnd, > Protection=46lags, =46ALSE); > ++ int krc =3D vm=5Fmap=5Fprotect(pVmMap, AddrStart, AddrEnd, > Protection=46lags, 0, VM=5FMAP=5FPROTECT=5FSET=5FPROT); > + IPRT=5F=46REEBSD=5FRESTORE=5FE=46L=5FAC(); > if (krc =3D=3D KERN=5FSUCCESS) > return VIN=46=5FSUCCESS; > > Seems that =5F=5F=46reeBSD=5Fversion has been bumped to 1300135 less th= an > 2 hours before 0659df6faddfb27ba54a2cae2a12552cf4f823a0 and thus > the patch could be made to depend on that =5F=5F=46reeBSD=5Fversion val= ue, > but I did not bother to add the condition since all my systems have > been updated to newer versions. > > Regards, STefan > > > --- memobj-r0drv-freebsd.o --- > > /usr/ports/emulators/virtualbox-ose-kmod/work/VirtualBox-5.2.44/out/f= reebsd.amd64/release/bin/src/vboxdrv/r0drv/freebsd/memobj-r0drv-freebsd.c= :887:80: > > error: too few arguments to function call, expected 6, have 5 > > int krc =3D vm=5Fmap=5Fprotect(pVmMap, AddrStart, AddrEnd, > > Protection=46lags, =46ALSE); > > =7E=7E=7E=7E=7E=7E=7E=7E=7E=7E=7E=7E=7E=7E =5E > > /usr/src/sys/vm/vm=5Fmap.h:517:5: note: 'vm=5Fmap=5Fprotect' declared= here > > int vm=5Fmap=5Fprotect(vm=5Fmap=5Ft map, vm=5Foffset=5Ft start, vm=5F= offset=5Ft end, > > =5E > > 1 error generated. > > *** =5Bmemobj-r0drv-freebsd.o=5D Error code 1 --60100b2a_46e87ccd_a665 Content-Type: application/pgp-signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: Canary PGP V3 iQJVBAABCgA/OBxEaW1hIFBhbm92IChGcmVlQlNELk9SRyBDb21taXR0ZXIpIDxm bHVmZnlARnJlZUJTRC5PUkc+BQJgEAspAAoJEPuLoJ3VOY8puFcQAKUHvvMXbGvL Io/p5PA1RFWB6CgU7Fo3RztoTI7rtUk1VmPtOBuaZnhMIdjwbahUG36yBBnc8kUh YdQDP2qyrSiCI0SUYBkJ+CDaQXjmfP/ftnS/1mnQmY3VG2JOEQPj1ZsGo7qsYHsK tqa2ZLFZ3hufGxi4y+wzTsK5BgY+ZVUaEDFaSIXENoJX6KmHzB2dL6YsGAXNPhbJ YApmdatABTHqwXtVETpZlYfcNpuLSuky1iIq3RP0vuraMtwrkWYd/wdqs8FpTGdq 1GTqbXbxoZdE0BhO88ZxpiIhyrusVHhM2nEIIuLXQpzx3O6WrZiZ/Y3BLcoju25e zxL93bx9FOvphBsCYhHanRySbH/JADZ0LbnpIMd/gMo5XgYxnAcINCNmHtQzJz+O rJjHtgJAFiAu+275uAJ54kLQBg+CB282ZR+s4SSTjbEK4oJOqntwcnudmPXtJ396 MCrgaYu8+XHNDio92dH978pb4rTcLaLNRFDc4+RWZZd8IPLtJHjAAhKSpwqkmHIH FtxikxmUv5ahGhha0hF3Ub02r4Wu8uOoPDVTDLQ9KSCPI0ns/jLp/Lic16sTLKCf c7/lAn5B9LZNlE49v42pI6LqSDOaaHNZykAklGzifhTKcbbzLgBztpY4NvUzd09x FIhy2Y7ysxUW8KjncAdrh4qXBY6GKe+H =f9BJ -----END PGP SIGNATURE----- --60100b2a_46e87ccd_a665--