From owner-svn-src-head@freebsd.org  Wed Jan 15 06:10:55 2020
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 62E4E221D63;
 Wed, 15 Jan 2020 06:10:55 +0000 (UTC)
 (envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (glebi.us [162.251.186.162])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 47yH4t6b4Gz47Rb;
 Wed, 15 Jan 2020 06:10:54 +0000 (UTC)
 (envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id 00F6Akgo090258
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
 Tue, 14 Jan 2020 22:10:46 -0800 (PST)
 (envelope-from glebius@freebsd.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id 00F6Ak2u090257;
 Tue, 14 Jan 2020 22:10:46 -0800 (PST)
 (envelope-from glebius@freebsd.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@freebsd.org using -f
Date: Tue, 14 Jan 2020 22:10:46 -0800
From: Gleb Smirnoff <glebius@freebsd.org>
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Cc: hselasky@freebsd.org, bz@freebsd.org, cem@freebsd.org
Subject: Re: svn commit: r356755 - in head/sys: net netinet netinet6
 netpfil/ipfw/nat64 sys
Message-ID: <20200115061046.GR39529@FreeBSD.org>
References: <202001150605.00F65Kc8011526@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202001150605.00F65Kc8011526@repo.freebsd.org>
User-Agent: Mutt/1.12.2 (2019-09-21)
X-Rspamd-Queue-Id: 47yH4t6b4Gz47Rb
X-Spamd-Bar: /
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-0.20 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_SPAM_MEDIUM(0.67)[0.669,0];
 ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US];
 NEURAL_HAM_LONG(-0.87)[-0.865,0]
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jan 2020 06:10:55 -0000

  Hi,

On Wed, Jan 15, 2020 at 06:05:20AM +0000, Gleb Smirnoff wrote:
T> Log:
T>   Introduce NET_EPOCH_CALL() macro and use it everywhere where we free
T>   data based on the network epoch.   The macro reverses the argument
T>   order of epoch_call(9) - first function, then its argument. NFC

I really want to reverse the argument order of epoch_call() as well.
The current order is really backwards:

     void
     epoch_call(epoch_t epoch, epoch_context_t ctx,
         void (*callback)(epoch_context_t));

Suggested declaration is:

     void
     epoch_call(epoch_t epoch, epoch_context_t ctx,
        void (*callback)(epoch_context_t));

This will be a very easy change, since today function is
used just in few places.

Before branching stable/12 we intentionally put this
note in epoch.9 manual page:

NOTES
     The epoch kernel programming interface is under development and is
     subject to change.

Any objections?

-- 
Gleb Smirnoff