From owner-freebsd-mobile Tue Oct 29 0:57:19 2002 Delivered-To: freebsd-mobile@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ADFCC37B401 for ; Tue, 29 Oct 2002 00:57:18 -0800 (PST) Received: from tasogare.imasy.or.jp (tasogare.imasy.or.jp [202.227.24.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 61EF143E3B for ; Tue, 29 Oct 2002 00:57:17 -0800 (PST) (envelope-from iwasaki@jp.FreeBSD.org) Received: from localhost (iwa@tasogare.imasy.or.jp [202.227.24.5]) by tasogare.imasy.or.jp (8.11.6+3.4W/8.11.6/tasogare) with ESMTP/inet id g9T8umY84770; Tue, 29 Oct 2002 17:56:48 +0900 (JST) (envelope-from iwasaki@jp.FreeBSD.org) Date: Tue, 29 Oct 2002 17:56:31 +0900 (JST) Message-Id: <20021029.175631.25480257.iwasaki@jp.FreeBSD.org> To: imp@bsdimp.com Cc: iedowse@maths.tcd.ie, freebsd-mobile@FreeBSD.ORG Subject: Re: Patch to fix/shorten "wi" freezes From: Mitsuru IWASAKI In-Reply-To: <20021029.004259.107520615.imp@bsdimp.com> References: <200210271800.aa11251@salmon.maths.tcd.ie> <20021029.122934.67876690.iwasaki@jp.FreeBSD.org> <20021029.004259.107520615.imp@bsdimp.com> X-Mailer: Mew version 2.2 on Emacs 20.7 / Mule 4.0 (HANANOEN) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-mobile@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Hi, > This is both right and wrong a the same time. It is right in that it > forces cardbus_detach_card to not power down the card. It is wrong in > that it fixes the problem one layer too high. cardbus_detach_card has > no business turning the power off if there are no children. Also, the > warning is bogus, imho. So, here's my patch that corrects these > problems. It eliminates NOWARN, eliminates the bogus printf and power > cycle, and adds a set of nice parens :-) I've just tested your patche, and confirmed problem was fixed related with suspend. Thanks! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-mobile" in the body of the message